Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Olympus client application due push notification changes #615

Open
ognjenns opened this issue Sep 18, 2017 · 1 comment
Open
Assignees
Milestone

Comments

@ognjenns
Copy link

The push notifications should be handled in the Application delegate class; We need to have communication with push data and resctomm sdk
therefore we need to change the applications sdk initialization, callbacks and business logic.

@ognjenns
Copy link
Author

After investigation, we realized that refactoring for push will include refactoring the almost all view controllers. We will put it on ice for now.
Here is the rough ides what needs to be done:

Current logic include RCDevice in view controllers.

The idea is to create new singleton class RCDeviceHandler and heleper classes (if we need them).
Currently, the device connection or RCDevice instance is passed through the majority of the view controllers.
I think we should remove that;
Instead I would handle all business logic inside RCDeviceHandler.
Communication between the RCDeviceHandler and view controllers will be done via protocols defined on RCDeviceHandler.
Also, intruducing RCDeviceHandler will help on handling push notifications.

Some of the changes (roughly):

  • KeypadViewController -> it will have RCDeviceHanlder instance and it will call methods for sending digits (we will not give the RCConnection to viewController)
  • ContactDetailsTableViewController -> We will remove Device (this view controller was use the instance only to give it via segue to the MessageTableViewController)
  • CallViewController -> Also, remove de device from it and handle only layout button (mute, hangup...) call the methods on the RCDeviceHandler
  • MainTableViewController, MessageTableViewController -> Remove callbacks and device; Impelement on RCDeviceHandler;
  • SettingsTableViewController, SipettingsTableViewController, ICESettingsTableViewController -> Remove RCDevice and intruucde RCDeviceHandler

@ognjenns ognjenns modified the milestones: Ognjen Sprint 3, Upcoming Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants