Use explicit `userInfo` keys for `NSManagedObjectContextDidSaveNotification` #2449

alexanderedge · 2016-08-03T17:21:47Z

In iOS 10 beta 4 there is a new key in the userInfo dictionary, managedObjectContext, so the existing collection operator causes a crash as it assumes all values are NSSets.

I have added explicit checking for inserted, deleted and updated objects.

In iOS 10 beta 4 there is another key in the `userInfo` dictionary, `managedObjectContext`, so the collection operator causes a crash as it assumes all values are `NSSet`s. I have added explicit checking for inserted, deleted and updated objects.

valeriomazzeo · 2016-08-03T19:13:10Z

it looks good to me 👍
@segiddins ?

segiddins · 2016-08-03T19:48:32Z

Code/CoreData/RKManagedObjectStore.h

@@ -24,6 +24,8 @@

 @class RKManagedObjectStore;

+extern NSSet *RKSetOfManagedObjectIDsFromManagedObjectContextDidSaveNotification(NSNotification *notification);


I'd just redeclare this in the test file, I don't think we should be exposing this as part of public API

maybe useful, an alternative is to put it into a private extension not exported in the public headers but imported into the test file rather than redeclare it, at least it's always in one place

Adding the definition immediately before the function in RKManagedObjectStore.m removes a “No previous prototype for function…” warning. Tests build by using `extern` with the same definition.

alexanderedge · 2016-08-03T21:02:27Z

Thanks a lot for the comments. I'll add separate private {h,m} files for this function as @valeriomazzeo suggests, as that seems neater than what we currently have here.

valeriomazzeo · 2016-08-04T08:37:04Z

Code/CoreData/RKManagedObjectStore_Private.h

+    unionObjectIDs(objectIDs,notification.userInfo[NSDeletedObjectsKey]);
+
+    return objectIDs;
+}


my preference would be to leave the implementation inside RKManagedObjectStore.m

alexanderedge · 2016-08-04T09:11:58Z

No problem – I've moved the impl into RKManagedObjectStore.m based on your comment.

valeriomazzeo · 2016-08-04T16:32:26Z

I think the only thing missing is to specify that header is private both in the project file and in the podspec.

alexanderedge · 2016-08-04T16:53:50Z

While I was there I noticed another header that should be private and added that (RKMappingOperation_Private.h)

SandyChapman · 2016-09-15T15:54:29Z

@segiddins @valeriomazzeo : Any idea when the next release is scheduled? I'd like to incorporate this fix into my project and would want to do it off a patch release rather than a specific commit.

NelepovDmitry · 2016-09-16T13:10:43Z

Hi every one, then it fix will be in cocoapods? Now there version RestKit 0.27.0 but still:

static NSSet *RKSetOfManagedObjectIDsFromManagedObjectContextDidSaveNotification(NSNotification *notification) { NSUInteger count = [[[notification.userInfo allValues] valueForKeyPath:@"@sum.@count"] unsignedIntegerValue]; NSMutableSet *objectIDs = [NSMutableSet setWithCapacity:count]; for (NSSet *objects in [notification.userInfo allValues]) { [objectIDs unionSet:[objects valueForKey:@"objectID"]]; } return objectIDs; }

SandyChapman · 2016-09-16T13:16:37Z

@NelepovDmitry : They haven't released a version with the fix. You can try this in your Podfile:

pod 'RestKit', :git => 'https://github.com/RestKit/RestKit.git', :commit => '13d98d5a6a5e06656ad040013dcae149b7cf8b99'

Sajjon · 2016-09-21T08:12:20Z

I also see this warning in the debugger:

userInfo = {
   NSTargetObjectUserInfoKey = "<_PFWeakReference: 0x1704211c0>";
   NSUnknownUserInfoKey = "@count";
}

I dont really understand, is this just a warning? Or has something indeed failed? Everything seams to be working... :S

RustamKhisamov · 2016-09-21T11:55:03Z

I used this commit
pod 'RestKit', :git => 'https://github.com/RestKit/RestKit.git', :commit => '9cbba9eb1b490c3c5e2873c8fba8e9c0fec1bf07'

…cation` (RestKit#2449) * Use specific `userInfo` keys In iOS 10 beta 4 there is another key in the `userInfo` dictionary, `managedObjectContext`, so the collection operator causes a crash as it assumes all values are `NSSet`s. I have added explicit checking for inserted, deleted and updated objects. * Expose function for testing * Add test case * Remove function from public interface Adding the definition immediately before the function in RKManagedObjectStore.m removes a “No previous prototype for function…” warning. Tests build by using `extern` with the same definition. * Add header for private function used in test * Move implementation into RKManagedObjectStore.m * Specify private headers in Podspec

shial4 · 2016-10-05T00:07:02Z

in what version of restKit it will be included avaiable from cocoapods?

devcarlos · 2016-10-05T14:42:27Z

We need this fix as soon as possible ready on CocoaPods

shial4 · 2016-10-05T22:18:12Z

This will come with https://github.com/RestKit/RestKit/issues/2459 correct?

valeriomazzeo · 2016-10-07T07:08:52Z

If anyone can confirm
pod 'RestKit', :git => 'https://github.com/RestKit/RestKit.git', :commit => '13d98d5a6a5e06656ad040013dcae149b7cf8b99'
fixes the issue, either me or @segiddins can make an hotfix release (0.27.1).

I didn't really follow on #2459

Does this pull request fixes it?

danielgronlund · 2016-10-10T10:41:11Z

@valeriomazzeo Yep, it does seem to resolve the exception issues for me! Hotfix release would be appreciated!

balazsnemeth · 2016-10-11T12:29:36Z

👍 for the hotfix release!

SriramKrishnan8 · 2016-10-13T06:13:06Z

@SandyChapman and @RustamKhisamov : I used the commits you had specified, but still the issue persists. Initially I tried updating the pod to the latest version, but that didn't work. I had to modify the code directly in RKManagedObjectStore.m and add the header file RKMappingOperation_Private.h. Only then it worked. Is there any other commit that works?

valeriomazzeo · 2016-10-16T10:41:51Z

I have started some work on #2466 and #2467 in order to release 0.27.1, but there are issues with some of the dependencies.

Once those two PR will be passing on Travis then we can release.
Any help is appreciated.

zsoltbalint · 2016-10-21T12:39:23Z

This fixed for me:
pod 'RestKit', :git => 'https://github.com/RestKit/RestKit.git', :commit => '13d98d5a6a5e06656ad040013dcae149b7cf8b99'

But it would be really good to have a stable version.

SandyChapman · 2016-10-21T12:43:20Z

@zsoltbalint : If it makes you feel any better, that commit is identical to the 0.27.0 release with the addition of the single fix required.

zsoltbalint · 2016-10-21T14:21:21Z

Thanks @SandyChapman , for clarification! 👍

* development: New changes to CocoaPods (RestKit#2443) Use explicit `userInfo` keys for `NSManagedObjectContextDidSaveNotification` (RestKit#2449) # Conflicts: # Code/CoreData/RKManagedObjectStore.m

…cation` (RestKit#2449) * Use specific `userInfo` keys In iOS 10 beta 4 there is another key in the `userInfo` dictionary, `managedObjectContext`, so the collection operator causes a crash as it assumes all values are `NSSet`s. I have added explicit checking for inserted, deleted and updated objects. * Expose function for testing * Add test case * Remove function from public interface Adding the definition immediately before the function in RKManagedObjectStore.m removes a “No previous prototype for function…” warning. Tests build by using `extern` with the same definition. * Add header for private function used in test * Move implementation into RKManagedObjectStore.m * Specify private headers in Podspec

see: RestKit/RestKit#2449

saiday · 2016-11-24T13:20:03Z

Can we have a CocoaPods release with this wonderful fixes?

To fix this problem: RestKit/RestKit#2449 (comment) Hopefully a real version will be released at some point. This required me to update cocoapods like so before running pod install: https://stackoverflow.com/questions/39980096/xcode8-cocoapods-abort-trap6/40438232#40438232

gvklooster · 2017-01-20T17:17:05Z

Any news on when the new version with this fix will be available?

honkmaster · 2017-01-21T10:24:31Z

Seems like Rest.Kit is somewhat dead ...

aron878 · 2017-02-01T09:05:00Z

pod 'RestKit', :git => 'https://github.com/RestKit/RestKit.git', :commit => '13d98d5a6a5e06656ad040013dcae149b7cf8b99'

It fixed my all issues with RestKit by upgrading to XCode 8 from XCode 7.

Thanks guys. 👍

ecstasy2 · 2017-02-13T22:28:54Z

Such a critical fix should have already been released :-(

honkmaster · 2017-02-13T22:50:59Z

Again: looks like RestKit died the typical open source death. Rest In Peace. It's sad to see, but developers move on, especially when they earn no money.

segiddins · 2017-02-13T22:58:38Z

see #2466

honkmaster · 2017-02-14T07:42:48Z

@segiddins I see that with #2466, you are hinting to a 0.27.1 realease. However, this PR is long overdue and not merged into the master. There is maybe an error with Travic CI, but "some" maintainer should take it as a starting point and make the final step.

The next sentences may sound harsh and I feel sorry in advance (as I really understand those situations): If you (or someone else) does not have the time to maintain the component please state this publicly by making RestKit deprecated. Maybe this also helps bringing other people to the project.

alexanderedge added 3 commits August 3, 2016 18:20

Use specific userInfo keys

2c0428f

In iOS 10 beta 4 there is another key in the `userInfo` dictionary, `managedObjectContext`, so the collection operator causes a crash as it assumes all values are `NSSet`s. I have added explicit checking for inserted, deleted and updated objects.

Expose function for testing

b207649

Add test case

ec29aea

segiddins reviewed Aug 3, 2016
View reviewed changes

Remove function from public interface

dbc4645

Adding the definition immediately before the function in RKManagedObjectStore.m removes a “No previous prototype for function…” warning. Tests build by using `extern` with the same definition.

Add header for private function used in test

0c7f705

valeriomazzeo reviewed Aug 4, 2016
View reviewed changes

Move implementation into RKManagedObjectStore.m

ac39b0b

rojo69 mentioned this pull request Aug 4, 2016

Context did save notification handle fix #2448

Closed

valeriomazzeo added the iOS 10 label Aug 4, 2016

Specify private headers in Podspec

9571c21

valeriomazzeo merged commit 9cbba9e into RestKit:development Aug 9, 2016

alexanderedge mentioned this pull request Aug 9, 2016

Xcode 8 error log #2451

Closed

vilinskiy-playdayteam mentioned this pull request Sep 15, 2016

Exception while saving context #2455

Closed

nmccann mentioned this pull request Sep 26, 2016

RKManagedObjectStore - observer of NSManagedObjectCnotextDidSaveNotification illegally threw exception #2459

Open

valeriomazzeo mentioned this pull request Oct 22, 2016

Fix iOS 10 bug #2470

Closed

ivkosh added a commit to ivkosh/RestKitMapper that referenced this pull request Nov 15, 2016

update to RestKit 0.27 API and iOS10

9f2a504

see: RestKit/RestKit#2449

ivkosh mentioned this pull request Nov 16, 2016

let RestKitMapper work with latest RestKit 0.27 xfyre/RestKitMapper#1

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use explicit `userInfo` keys for `NSManagedObjectContextDidSaveNotification` #2449

Use explicit `userInfo` keys for `NSManagedObjectContextDidSaveNotification` #2449

alexanderedge commented Aug 3, 2016

valeriomazzeo commented Aug 3, 2016

segiddins Aug 3, 2016

valeriomazzeo Aug 3, 2016

alexanderedge commented Aug 3, 2016

valeriomazzeo Aug 4, 2016

alexanderedge commented Aug 4, 2016

valeriomazzeo commented Aug 4, 2016

alexanderedge commented Aug 4, 2016

SandyChapman commented Sep 15, 2016

NelepovDmitry commented Sep 16, 2016

SandyChapman commented Sep 16, 2016

Sajjon commented Sep 21, 2016

RustamKhisamov commented Sep 21, 2016

shial4 commented Oct 5, 2016

devcarlos commented Oct 5, 2016

shial4 commented Oct 5, 2016

valeriomazzeo commented Oct 7, 2016 •

edited

danielgronlund commented Oct 10, 2016

balazsnemeth commented Oct 11, 2016

SriramKrishnan8 commented Oct 13, 2016

valeriomazzeo commented Oct 16, 2016 •

edited

zsoltbalint commented Oct 21, 2016

SandyChapman commented Oct 21, 2016

zsoltbalint commented Oct 21, 2016

saiday commented Nov 24, 2016

gvklooster commented Jan 20, 2017

honkmaster commented Jan 21, 2017

aron878 commented Feb 1, 2017

ecstasy2 commented Feb 13, 2017

honkmaster commented Feb 13, 2017

segiddins commented Feb 13, 2017

honkmaster commented Feb 14, 2017 •

edited

		@@ -24,6 +24,8 @@

		@class RKManagedObjectStore;

		extern NSSet RKSetOfManagedObjectIDsFromManagedObjectContextDidSaveNotification(NSNotification notification);

Use explicit userInfo keys for NSManagedObjectContextDidSaveNotification #2449

Use explicit userInfo keys for NSManagedObjectContextDidSaveNotification #2449

Conversation

alexanderedge commented Aug 3, 2016

valeriomazzeo commented Aug 3, 2016

segiddins Aug 3, 2016

Choose a reason for hiding this comment

valeriomazzeo Aug 3, 2016

Choose a reason for hiding this comment

alexanderedge commented Aug 3, 2016

valeriomazzeo Aug 4, 2016

Choose a reason for hiding this comment

alexanderedge commented Aug 4, 2016

valeriomazzeo commented Aug 4, 2016

alexanderedge commented Aug 4, 2016

SandyChapman commented Sep 15, 2016

NelepovDmitry commented Sep 16, 2016

SandyChapman commented Sep 16, 2016

Sajjon commented Sep 21, 2016

RustamKhisamov commented Sep 21, 2016

shial4 commented Oct 5, 2016

devcarlos commented Oct 5, 2016

shial4 commented Oct 5, 2016

valeriomazzeo commented Oct 7, 2016 • edited

danielgronlund commented Oct 10, 2016

balazsnemeth commented Oct 11, 2016

SriramKrishnan8 commented Oct 13, 2016

valeriomazzeo commented Oct 16, 2016 • edited

zsoltbalint commented Oct 21, 2016

SandyChapman commented Oct 21, 2016

zsoltbalint commented Oct 21, 2016

saiday commented Nov 24, 2016

gvklooster commented Jan 20, 2017

honkmaster commented Jan 21, 2017

aron878 commented Feb 1, 2017

ecstasy2 commented Feb 13, 2017

honkmaster commented Feb 13, 2017

segiddins commented Feb 13, 2017

honkmaster commented Feb 14, 2017 • edited

Use explicit `userInfo` keys for `NSManagedObjectContextDidSaveNotification` #2449

Use explicit `userInfo` keys for `NSManagedObjectContextDidSaveNotification` #2449

valeriomazzeo commented Oct 7, 2016 •

edited

valeriomazzeo commented Oct 16, 2016 •

edited

honkmaster commented Feb 14, 2017 •

edited