Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove react-tap-event-plugin from Library #5

Closed
JonatanSalas opened this issue Apr 20, 2017 · 1 comment
Closed

Remove react-tap-event-plugin from Library #5

JonatanSalas opened this issue Apr 20, 2017 · 1 comment
Assignees
@JonatanSalas
Labels
high priority
Projects
next

Comments

@JonatanSalas
Copy link

JonatanSalas commented Apr 20, 2017 •
edited
Loading

Using react-tap-event-plugin to inject touch tap event support from a Library is not recommend by the ReactJS. Actually we're injecting touch tap event through Layout component, we need to remove it.

This plugin should be called inside of an App just before calling ReactDOM.render method.
@JonatanSalas JonatanSalas self-assigned this Apr 20, 2017
@JonatanSalas JonatanSalas added this to Testing in next Apr 20, 2017
@JonatanSalas JonatanSalas moved this from Testing to In Progress in next Apr 20, 2017
@JonatanSalas JonatanSalas moved this from In Progress to Done in next Apr 22, 2017
@JonatanSalas
Copy link
Author

Closed as this is currently done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonatanSalas JonatanSalas

Labels
high priority
Projects
next
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonatanSalas