Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Fix package manager installation #45

Merged
merged 8 commits into from May 10, 2018
Merged

Fix package manager installation #45

merged 8 commits into from May 10, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2018

Issue Link πŸ”—

Resolves #44.

Goals ⚽

Makes it possible to install and use Restofire in Swift Package Manager packages.

Implementation Details 🚧

  • Moves the Swift tools version specification to the top of Package.swift, so that the version is correctly set. See here for details.
  • Updates the package specification in Package.swift to package description v4 syntax (similary to how the package template that swift package init produces is structured).
  • Adds a missing Foundation import in RestofireRequest.swift.

Testing Details πŸ”

Check out a working example project here:

git clone git@github.com:dnlggr/RestofireTest.git && cd RestofireTest
swift run

Let me know what you think! πŸ™‚

@ghost ghost mentioned this pull request Apr 30, 2018
1 task
@ghost
Copy link
Author

ghost commented May 2, 2018

Not sure why the tests fail. It doesn't seem to be related to the changes I made. πŸ€”

@rahul0x24
Copy link
Member

@dnlggr Don’t worry about that. That’s probably because the web service is not mocked. I will take care of that. I will merge this ASAP. Thanks

Sent with GitHawk

@rahul0x24 rahul0x24 merged commit 2917b69 into Restofire:develop May 10, 2018
@rahul0x24
Copy link
Member

Merged. Sorry for the delay. You may now use the tag from 4.0.1 in your Package.swift. πŸŽ‰

@ghost ghost deleted the fix-swift-pm-installation branch May 10, 2018 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants