Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'grunt-retire' complaining about latest version of grunt-retire 0.3.6 #17

Closed
aslamj opened this issue Dec 10, 2014 · 9 comments
Closed
Assignees

Comments

@aslamj
Copy link

aslamj commented Dec 10, 2014

htmlparser2 3.8.2 has known vulnerabilities: fb55/htmlparser2#105
grunt-retire 0.3.6
↳ grunt-contrib-jshint 0.10.0
↳ jshint 2.5.10
↳ htmlparser2 3.8.2

@aslamj aslamj changed the title 'grunt require:node' reporting issue with latest grunt-retire version 0.3.6 'grunt-retire' complaining about latest version of grunt-retire 0.3.6 Dec 10, 2014
@eoftedal
Copy link

Hmm. I can't reproduce this locally. In our printout it looks like grunt-retire has a direct dependency to htmlparser2, though I cannot find this in the manifest.json.

@phun-ky
Copy link

phun-ky commented Dec 11, 2014

I could only find it in the grunt-contrib-jshint-module

@phun-ky
Copy link

phun-ky commented Dec 11, 2014

Found it! (I think):

Searching 80 files for "htmlparser" (case sensitive)

C:\Users\QE1\Workspace\retire.js\repository\npmrepository.json:
  136     "vulnerabilities" : [ { "below" : "1.4.3", "info" : [ "https://github.com/punkave/sanitize-html/issues/29" ] } ]
  137   },  
  138:  "htmlparser2": {
  139:    "vulnerabilities" : [ { "below" : "3.8.3", "info" : [ "https://github.com/fb55/htmlparser2/issues/105" ] } ]
  140   },
  141   "sequelize-restful": {

2 matches in 1 file

@phun-ky
Copy link

phun-ky commented Dec 11, 2014

Created issue at Jshint project to make them update the version in their package.json: jshint/jshint#2029

But as the maintainer of htmparser2 will not fix this any time soon, we will have to wait :/

@eoftedal
Copy link

Nice work, @phun-ky

@kozmic
Copy link
Member

kozmic commented Dec 11, 2014

Quite funny issue, retire finds a vulnerability in its own dependencies by itself... omg! :) Nice work!

@phun-ky
Copy link

phun-ky commented Dec 12, 2014

That's a thought. Should we have a continuous job for grunt-retire/retire to check for vulnerable dependencies? as a test suite on a CI plattform, i.e. Travis?

And if we do not have one (this is not quite related), a simple example in the readme on how to set up test cases for this?

@eoftedal
Copy link

Click me:
retire

@phun-ky
Copy link

phun-ky commented Dec 13, 2014

Woop woop! Very nice!

@kozmic kozmic self-assigned this Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants