Unable to distribute to App Store Connect, Invalid bundle

[melih-veloxia]

• [ ✅ ] I have updated Purchases SDK to the latest version
• [ ✅ ] I have read the Contribution Guidelines
• [ ✅ ] I have searched the Community
• [ ✅ ] I have read docs.revenuecat.com
• [ ✅ ] I have searched for existing Github issues

Starting from 2020x, Unity introduced a new standard for Unity's iOS builds wherein plugins and files are contained within UnityFramework.framework (which is where I see RevenueCat’s generated code and other files). That's why when we try to upload our binary with RevenueCat to Apple Store Connect through Xcode, we get the error: ERROR ITMS-90206: "Invalid Bundle. The bundle at 'APPNAME.app/Frameworks/UnityFramework.framework' contains disallowed file 'Frameworks'.". Before installing RevenueCat, there wasn't any problem.

1. Environment

   1. Platform: iOS
   2. SDK version: 3.5.0
   3. OS + version: MacOS 11.3.1
   4. Xcode/Android Studio version: 12.5.1
   5. Unity version: 2020.3.25f1
   6. How widespread is the issue. Percentage of devices affected: 100%

2. Debug logs that reproduce the issue
   None

3. Steps to reproduce, with a description of expected vs. actual behavior

   1. Build to Xcode with Unity 2020.3.25f1 after RevenueCat installation
   2. Archive the build
   3. Try to distribute to App Store Connect

4. Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)
   As a workaround, one may follow the steps below:

   1. Build project to Xcode from Unity like you normally would
   2. In the project view, select the target that is your project (usually called "Unity-IPhone" from what I've seen)
   3. Click Build Phases
   4. Click that small plus sign that’s really easy to miss at the top of the build phases section of Xcode
   5. Choose New Run Script Phase
   6. Expand the newly added Run Script
   7. Paste this script in there:
      cd "${CONFIGURATION_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/Frameworks/UnityFramework.framework/" if [[ -d "Frameworks" ]]; then rm -fr Frameworks fi

Additional context
These additional steps prevent us to use our CI/CD pipeline, that’s why an immediate fix is required.

References:
https://developer.apple.com/forums/thread/654980
https://support.wikitude.com/support/discussions/topics/5000096581

[ghost]

Hello! It doesn't seem like we have quite enough information to send this to a human yet to help out. We would love if you could provide more details about your issue by following the template without modifying any of the pre-filled text. If you're looking for support, head over to our Community.

[aboedo]

hi @melih-veloxia! Thanks for reporting! Sorry about the bot, the ticket is fine.
I'm gonna dig into this and report back

[aboedo]

I can confirm that with Unity 2020.3.27f1, I am able to reproduce the error when validating a build of our Unity Subtester app with Organizer.

I'm a curious, though, about the setup that led to the .framework being there.
We use Cocoapods to distribute our .framework with Unity, through the External Dependency Manager.

Cocoapods doesn't actually create a Frameworks folder, it instead just creates a single, static library that embeds all frameworks.

You can even see this in the project's build phases.

I believe you're correct in the problem being a change in Unity. I don't think that it's entirely related to our SDK, although I'm still investigating and not discarding the possibility.

I'll report back when I know more.

Thanks again for reporting!

[melih-veloxia]

@aboedo Thanks for your quick reply. Just like I said, we use bunch of other SDKs with cocoapods through EDM4U and without RevenueCat, there isn't any problem.

[aboedo]

@melih-veloxia that's good to know. Could you provide a couple of examples of the SDKs that you have through cocoapods that do work with no problem, so I can try to see what they're doing differently?

[melih-veloxia]

@aboedo

• Facebook SDK
• Most of the tools from Firebase SDK
• AppsFlyer SDK
• IronSource SDK with most of the adaptors
• GameAnalytics SDK
• OneSignal SDK

[aboedo]

Thanks!! I'll take a look

[aboedo]

@melih-veloxia I made a PR for the fix, #84.
The PR adds a post install script that will ensure that ALWAYS_EMBED_SWIFT_LIBRARIES is set to NO.

It'll make it into a release soon.

In the meantime, you can also solve this for your project by clicking on the target in the Xcode project, then looking for ALWAYS_EMBED_SWIFT_LIBRARIES and setting it to NO (you may need to do it for other targets too).

I tried it in the same app that I used to reproduce the issue and the issue was gone.

Hope this helps!! Thanks again for reporting and for being so responsive!

[melih-veloxia]

Hey @aboedo! Thanks, will give it a try with the pull request and let you know! Thanks for the quick solution.

[melih-veloxia]

I merged your 2 pull requests into our project and it works with the CI/CD pipeline!

Closing the issue right now, thanks for your cooperation.

[aboedo]

Thanks for the confirmation @melih-veloxia!!! I'll be making an official release with both PRs today. Let us know if you run into any more issues!