Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

Network IDs in entities should simply use the EntityIds class constants in PocketMine #329

Open
Sandertv opened this issue Sep 8, 2018 · 1 comment
Labels
Category: Enhancement This makes the code quality better Category: Suggestion

Comments

@Sandertv
Copy link
Contributor

Sandertv commented Sep 8, 2018

Required Information

PocketMine-MP Version: 3.2.0
Plugin Version: *
Where you got the plugin: *

Optional Information

PHP version: *
Other Installed Plugins: *
OS Version: *

Description

The Data constants were previously used for the entity IDs, but PocketMine has all of the entity network ID constants in the core already since some time. The current constants in PEX are redundant and could be removed. This also makes it easier to update should the IDs change.

@95CivicSi
Copy link
Collaborator

Let's hope they don't but yeah, this could be important. I'll probably fix this by updating the Data IDs to be linked to the PocketMine-MP internal IDs where possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Enhancement This makes the code quality better Category: Suggestion
Projects
None yet
Development

No branches or pull requests

2 participants