Modget crashes Minecraft on startup

[second2050]

Installing Modget makes it impossible to start Minecraft, it will always crash on startup.

Tested Minecraft versions: 1.18; 1.17
Tested Modget version: 0.4.0+1.17
Minecraft Launcher used: MultiMC5 0.6.14-develop-3019
Java version: OpenJDK 17.0.1
OS: Windows 10 21H2

Log Files:
crash-modgetAndModmenu.txt
crash-onlyModget.txt
crash-onlyModget117.txt
modgetAndModmenu.log
onlyModget.log
onlyModget117.log

[TacoMonkey11]

you need to install fabric api
https://modrinth.com/mod/fabric-api/version/RSZHmY2f
@NebelNidas is FAPI in the dependencies? If not adding it should be top priority xD

[TacoMonkey11]

Ok so I just checked the dependencies for modget-core and it seems that the networking api is listed, very odd

[second2050]

Okay on a clean instance with only Fabric API + Modget on MC 1.18 it works,
now I'm confused as to why my "normal" instance still crashes:
crash-2021-12-17_02.25.30-client.txt
2021-12-17-2.log.gz

This instance has multiple mods, including Fabric API and including Modget crashes it still, this is most likely another problem then.

[thefirethirteen]

Ok so I just checked the dependencies for modget-core and it seems that the networking api is listed, very odd

Yeah but modget bundles it, so you shouldn't have to install fabric(-api)

[pozitp]

Try to install latest version of Mod Menu, Cloth Config API and Fabric API

On all my instances its works fine

[NebelNidas]

We do indeed require the Fabric networking and command API modules, but these should be bundled with Modget itself. Weird that you are seeing these crashes, I will look into it!

[NebelNidas]

Ok, for the first logs you posted, the situation is clear: The version of fabric-networking-api-v1 we bundle is the 1.16 one, and apparently it doesn't work with the later Minecraft versions (must have missed this somehow). As soon as you add Fabric API, Fabric Loader automatically chooses the newer one, so this issue doesn't happen anymore.

Your second logs however are a bit weird. In the first one, Fabric Loader doesn't seem to be able to find the com.github.reviversmc.modget.minecraft.Modget class? Maybe this has something to do with the order your mods have been loaded, it could be that in your case modget-minecraft-1.17 was loaded before modget-minecraft-core which could cause this issue. I will look into how to define the correct loading order!

With the second log of your second message however, there's definitely something else going on. Somehow your game can't find a specific dll file, which can't be caused by us. I'd report that one to MultiMC!

[NebelNidas]

Loading order and Fabric API module bundling should now be fixed! Can you try the latest CI build, @second2050? https://github.com/ReviversMC/modget-minecraft/actions/runs/1592745504#artifacts

[second2050]

The CI build works and it does not crash my Minecraft instance anymore.

[NebelNidas]

Perfect! Will publish it soon :)