Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you aware of https://github.com/dims/etcd3-gateway ? #112

Open
nelljerram opened this issue Oct 29, 2019 · 9 comments
Open

Are you aware of https://github.com/dims/etcd3-gateway ? #112

nelljerram opened this issue Oct 29, 2019 · 9 comments
Labels
question Further information is requested

Comments

@nelljerram
Copy link

How would you say etcd3-py compares against etcd3-gateway? Could you work together instead of apparently duplicating effort?

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label question to this issue, with a confidence of 0.84. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the question Further information is requested label Oct 29, 2019
@Revolution1
Copy link
Owner

Revolution1 commented Oct 30, 2019

this repo supports python2 and python3 with asyncio

and stateful utils with human friendly api

@nelljerram
Copy link
Author

Thanks. I think etcd3-gateway also supports python2 and python3, but maybe not asyncio.

@Revolution1
Copy link
Owner

yeah, it does support python2

@heitorPB
Copy link

etcd3-gateway does not support user/pass authentication. We are replacing with etcd3-py

@nelljerram
Copy link
Author

FWIW, we implemented user/pass authentication by subclassing the Etcd3Client class, as you can see here: https://github.com/projectcalico/calico/blob/master/networking-calico/networking_calico/etcdv3.py#L388-L472

@heitorPB
Copy link

@neiljerram that is a simple solution, I liked it. Is there a reason it was not upstreamed?

@nelljerram
Copy link
Author

@heitorPB Ah, good question!

I don't recall thinking about this carefully at the time, but I guess the thought in my mind was that the solution might not work for all possible uses of Etcd3Client. As the commenting says, I was comfortable that it works in all the cases that Calico (my project) needs - but it's possible that there are other cases not covered.

Nevertheless, I think it's right to try upstreaming, and then the discussion can discuss that - so will plan to do this shortly.

@heitorPB
Copy link

heitorPB commented May 6, 2022

I'd be happy to help you if you need! I created an issue on their bugtracker with this request: https://bugs.launchpad.net/python-etcd3gw/+bug/1970750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants