Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading invalid sdf #69

Closed
jmbadia opened this issue Nov 26, 2020 · 2 comments
Closed

loading invalid sdf #69

jmbadia opened this issue Nov 26, 2020 · 2 comments

Comments

@jmbadia
Copy link
Contributor

jmbadia commented Nov 26, 2020

Hi,
I parsed negative LC-MS/MS spectra from MoNA by using the compound_tbl_sdf(sdf file) function. It returns the following warning;

In read.SDFset(file) :
    54 invalid SDFs detected. To fix, run: valid <- validSDF(sdfset); sdfset <- sdfset[valid]

resulting in a result with invalid SDF we know nothing about
Maybe we could offer an argument ( compound_tbl_sdf(..., onlyValid) ) in order not to load such invalid SDFs by applying the code suggested by the warning.

@jmbadia jmbadia changed the title sdf not loading invalid sdf Nov 26, 2020
jorainer added a commit that referenced this issue Nov 27, 2020
- Add parameter `onlyValid` to `compound_tbl_sdf` (issue #69).
@jmbadia
Copy link
Contributor Author

jmbadia commented Nov 29, 2020

Thanks @jorainer . Looks great to me.

@jorainer
Copy link
Member

I'm closing the issue now - feel free to re-open if it's not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants