Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Marking Group filter back as a default filter #72

Closed
brittsikora opened this issue Jun 25, 2018 · 2 comments
Closed

Add Marking Group filter back as a default filter #72

brittsikora opened this issue Jun 25, 2018 · 2 comments

Comments

@brittsikora
Copy link

brittsikora commented Jun 25, 2018

When I was creating documentation for the latest release, I noticed that the Marking Group and Visit filters were missing.

Test notes

  • By default a filter labeled Marking Group (and one labeled Visit/Folder) should appear in the controls, both multi-selects.
  • The setting associated with each is marking_group_col and visit_col, and defaults to Query Open By: Marking Group and Visit/Folder respectively.
This was referenced Jun 25, 2018
@emmorris emmorris added this to the v1.2.1 milestone Jul 11, 2018
@emmorris emmorris added this to To do in v1.2.1 via automation Jul 11, 2018
@emmorris
Copy link

emmorris commented Jul 11, 2018

DMEDS requested that we add a marking group filter to the chart as a default. I believe adding back what was already there is previous versions will give them what they need. We had just switched it to a configuration option somewhere along the way. They would like a filter that lets the user select All, System, DM, CRA for the marking group. That will allow the CRAs to focus on the queries they opened and the DMs to focus on the queries they opened.

They didn't mention the missing Visit filter, so I'll ask them if that one is also important.

@emmorris emmorris changed the title Investigate Missing Filters Add Marking Group filter back as a default filter Jul 11, 2018
@samussiah samussiah moved this from To do to In progress in v1.2.1 Jul 13, 2018
@samussiah samussiah moved this from In progress to Done in v1.2.1 Jul 13, 2018
@dschwentker
Copy link

Tested and passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v1.2.1
  
Done
Development

No branches or pull requests

3 participants