Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unexpected visits systematically #68

Closed
rtbailey opened this issue Jan 15, 2018 · 1 comment
Closed

Handle unexpected visits systematically #68

rtbailey opened this issue Jan 15, 2018 · 1 comment
Milestone

Comments

@rtbailey
Copy link
Contributor

rtbailey commented Jan 15, 2018

Depending on how unscheduled visits are displayed on the x-axis, the chart can have some unintended behavior.

(See related issue for Results Over Time: RhoInc/safety-results-over-time#43)

If visits are displayed purely chronologically, the challenge is that you end up creating a new event type that shows up in the middle of the data, but for only a small number of data points. See example of visits 2.1 and 4.1 below:
image

Our primary medical monitor user has proposed that to fix this, we sort all Unscheduled visits to the far right end of the chart, where they are still visible, but they don't interfere with seeing the data flow through expected visits. The problem here is that the chart sometimes connects these points in a non-linear way:
example2

Proposed solutions:

  1. Retain visits in numerical order, but create a toggle that lets the user "Hide unscheduled visits"
  2. Force the chart to connect the dots in the same order as the axis is drawn

Test notes

Test out the new "Visits without data" and "Unscheduled visits" controls in CAT with the safetyData/ADBDS.csv data file (not safetyData-queries/ADBDS.csv).

Confirm that:

  • Unscheduled Visits and Visits with no data are shown/hidden when the toggle changes.
  • Change measure to "Alkaline Phosphatase (ALP)" and confirm that visits with no data are shown/hidden when the toggle changes.
  • Test with the above with groups active (settings: {groups:["RACE"]})
  • Unscheduled visits are shown on initial load with {"unscheduled_visits":true}
  • Visits with no data are shown on initial load with {"visits_without_data": false}
  • Only the visits are hidden/shown when explicitly specified using {unscheduled_visit_values:["Unscheduled 2.1","Screening"]}
@samussiah samussiah added this to the v2.2.0 milestone Jan 26, 2018
@samussiah samussiah added this to To Do in v2.2.0 via automation Jan 26, 2018
@samussiah samussiah removed this from To Do in v2.2.0 Jan 26, 2018
@jwildfire
Copy link
Contributor

Borrowed test notes from RhoInc/safety-results-over-time#43 (pasted above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants