Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpl 3.4 drops font_manager._rebuild() function and breaks design imports #96

Closed
bolliger32 opened this issue Mar 26, 2021 · 1 comment · Fixed by #97
Closed

mpl 3.4 drops font_manager._rebuild() function and breaks design imports #96

bolliger32 opened this issue Mar 26, 2021 · 1 comment · Fixed by #97
Assignees

Comments

@bolliger32
Copy link
Member

Description

Our CI pipeline just broke and it's b/c matplotlib just released v3.4.0. In this version there is no more _rebuild() function within the matplotlib.font_manager module. We call this function here:

from matplotlib.font_manager import _rebuild

It looks like the font loading lines above L129 are all commented out, so do we need this anymore? It wasn't immediately clear to me why matplotlib took it out or what the proper way to rebuild the font cache is now, but if we don't need it anymore we could remove that line. Until then, it's blocking as it breaks our CI

@delgadom do you know if we still need that _rebuild call?

@delgadom
Copy link
Member

dang. no we don't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants