Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the site ID for multi sites settings. #21

Merged
merged 5 commits into from
Jul 9, 2018

Conversation

JorgeAnzola
Copy link
Contributor

In my multi-site setup, I found out that when saving an entry, only the last site's version of the entry will be indexed.

i.e. Two sites (languages): English, Dutch.
Editing the entry in English and saving will outcome with the Dutch version of the entry indexed in Algolia, as it's the last site saved on Craft.

@riasvdv
Copy link
Collaborator

riasvdv commented Jul 7, 2018

Hi Jorge, thanks for the PR!

The change to the ObjectID is great, but I'd leave out the siteLanguage, people can add that manually if they want but you might have a multisite with content in the same language and then the field is unnecessary.

@riasvdv
Copy link
Collaborator

riasvdv commented Jul 7, 2018

Oh and don't mind the StyleCI, I'll fix that when merging

@riasvdv riasvdv merged commit c5e8663 into studioespresso:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants