Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magic-string@0.16.0 or later versions breaks buble #111

Closed
kzc opened this issue Nov 20, 2016 · 5 comments
Closed

magic-string@0.16.0 or later versions breaks buble #111

kzc opened this issue Nov 20, 2016 · 5 comments

Comments

@kzc
Copy link
Contributor

kzc commented Nov 20, 2016

buble works correctly with magic-string@0.15.2.

buble fails 41 tests with magic-string@0.16.0.

3f6dd4d is the commit that breaks buble.

@kzc
Copy link
Contributor Author

kzc commented Nov 24, 2016

@Rich-Harris I recommend to leave buble with the older version of magic-string for now until the entire PR backlog is merged into buble.

@Rich-Harris
Copy link
Owner

@kzc Agree. Apologies I haven't been very responsive on that project recently – would be very happy to give you the commit bit if you'd like, just let me know

@kzc
Copy link
Contributor Author

kzc commented Nov 24, 2016

@Rich-Harris Thanks, but I'm good as a drive-by patcher for now. I am only using buble as a faster babel 5 and it addresses the ES6 feature subset I need.

@kzc
Copy link
Contributor Author

kzc commented Nov 24, 2016

I think 3f6dd4d alters the magic-string move() behavior in some way. The destructuring transforms in particular use fairly complicated inserts, remove()s and moves()s and may rely on some unforeseen side effects of the previous implementation.

@kzc kzc changed the title magic-string@0.16.0 breaks buble magic-string@0.16.0 or later versions breaks buble Jan 26, 2017
@adrianheine
Copy link

This can be closed now that you migrated bublé to magic-string@^0.22.4.

@kzc kzc closed this as completed Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants