Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer Code Review - Week 6 #2

Closed
LIBERCOSOFT opened this issue Sep 20, 2022 · 0 comments
Closed

Peer Code Review - Week 6 #2

LIBERCOSOFT opened this issue Sep 20, 2022 · 0 comments

Comments

@LIBERCOSOFT
Copy link

Nice work 馃憤 , but for more semantic meaning you can:

  • Put all your elements after the body tag in a main tag which also helps with SEO.
  • Divide your code based on the section tag wrapping your h1 element in a header tag.
  • Using the alert function in your javascript file is also not best practice due to the less control of customization you have over it.

Happy Coding! 馃槂
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LIBERCOSOFT @RichardChileya