Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with unseparated Grid Tables in MM v2.3.5 #904

Closed
jbridgy opened this issue Jan 23, 2022 · 1 comment
Closed

Issues with unseparated Grid Tables in MM v2.3.5 #904

jbridgy opened this issue Jan 23, 2022 · 1 comment
Assignees
Labels

Comments

@jbridgy
Copy link

jbridgy commented Jan 23, 2022

Grid tables that are not separated by an empty line as in the following example are not handled correctly by the commands Format Table and Edit Table.

+----+----+
| A1 | B1 |
+====+====+
| A2 | B2 |
+----+----+
+----+----+
| A1 | B1 |
+====+====+
| A2 | B2 |
+----+----+

Issues:

  1. The command Format Table applied to either table deletes both tables and silently writes the file MarkdownMonsterErrors.txt.

  2. The command Edit Table applied to either table pops up the error message
    image
    and writes the file MarkdownMonsterErrors.txt.

@RickStrahl RickStrahl added the bug label Jan 24, 2022
@RickStrahl RickStrahl self-assigned this Jan 24, 2022
@RickStrahl
Copy link
Owner

RickStrahl commented Jan 24, 2022

FWIW, this is invalid markdown. If you look at render output you can see it the parser chokes on that too. The empty line between tables is required.

However, we shouldn't crash and I think MM should be able to pick up the table for editing regardless. I've made the change so it respects the first table boundary.

Incidentally the crash wasn't caused by the table parsing, but rather by the status display, which wasn't initialized yet So this actually fixes two issues 😄.

Fixed for next update (2.3.6+).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants