Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resx file generator does not write xml declarations #3

Closed
rinkeb opened this issue May 15, 2014 · 2 comments
Closed

Resx file generator does not write xml declarations #3

rinkeb opened this issue May 15, 2014 · 2 comments

Comments

@rinkeb
Copy link

rinkeb commented May 15, 2014

Hi Rick,

DbResXConverter writes resx files without a proper xml declaration.

The culprit seems to be Westwind.Globalization/SupportClasses/DbResXConverter.cs, line 337. This line intends to write the xml template to file by writing the root child element, thereby ignoring the xml declaration.

@RickStrahl
Copy link
Owner

Apologize for missing this for so long. Added the appropriate processing instruction header.

FWIW, while it's certainly better to write the PI, have you actually seen a failure because of it missing? The stock PI and default formatting for XmlWriter should not cause any problems if the PI is actually missing and as far as I can see the Resx resources generated work fine.

@rinkeb
Copy link
Author

rinkeb commented Jan 29, 2015

Great, thanx for fixing it anyway.

According to my collegae, Visual Studio did have problems reading the resx files without the xml declaration. (Otherwise he would not have made a problem about it ;-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants