New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Enum Support #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
du-toit
added
the
enhancement
Adding new behavior or change the way an existing feature works.
label
May 5, 2022
Halfnelson0
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces encoding and decoding support for
enum
types and their variants.Implementation
Consider this enum:
Each variant is encoded as such:
Enum::Unit
=>4:Unit
.Enum::NewType(50)
=>d 7:NewType i50e e
.Enum::Tuple(25, 50)
=>d 5:Tuple l i25e i50e e e
Enum::Struct { a: 25, b: 50 }
=>d 6:Struct d 1:a i25e 1:b i50e e e
Note that I only added whitespace to the examples above so they are more readable.
I believe these changes are backwards-compatible, since no items were added or removed from the API. Because of this, I've bumped the package version to
0.5.4
and updated the readme accordingly.Upon a successful merge, this PR closes #2.