Multiline comments generation issue

[vadimi]

Hello, after PR #1346 code generation for multiline comments produces invalid <summary> xml doc.

For example:

    TestType:
      type: object
      properties:
        code:
          type: string
          description: |
            * test1
            * test2

produces the following c# code:

    [System.CodeDom.Compiler.GeneratedCode("NJsonSchema", "13.15.3.0 (NJsonSchema v10.6.4.0 (Newtonsoft.Json v13.0.0.0))")]
    public partial class TestType
    {
        /// <summary>* test1
        /// <br/>* test2
    </summary>
        [Newtonsoft.Json.JsonProperty("code", Required = Newtonsoft.Json.Required.DisallowNull, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
        public string Code { get; set; }

        private System.Collections.Generic.IDictionary<string, object> _additionalProperties = new System.Collections.Generic.Dictionary<string, object>();

        [Newtonsoft.Json.JsonExtensionData]
        public System.Collections.Generic.IDictionary<string, object> AdditionalProperties
        {
            get { return _additionalProperties; }
            set { _additionalProperties = value; }
        }

    }

As you see the closing </summary> tag doesn't start with /// which breaks the compilation

[RicoSuter]

Yes, "\n" are not removed anymore which causes this problem...

/cc @lahma any reason why this regression has been introduced?

[kvantetore]

It seems like the issue was introduced in 463d246 by substituting
.Replace("\n", "\n" + string.Join("", Enumerable.Repeat(" ", tabCount)) + "/// ")
with a call to AddPrefixToBeginningOfNonEmptyLines() in ConversionUtilities.cs line 264.

The AddPrefixToBeginningOfNonEmptyLines() kind of makes sense for the | tab filter, but does not work as intended for the | csharpdocs filter. Imo /// should be added to empty lines as well as non-empty lines.

[lahma]

I'll have a look.

[lahma]

Fixed in #1463

[vadimi]

thanks for fixing the issue!