Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Like song from playbar only/basic view #478

Closed
sarahrobichaud opened this issue May 25, 2020 · 3 comments · Fixed by #507
Closed

[FEATURE REQUEST] Like song from playbar only/basic view #478

sarahrobichaud opened this issue May 25, 2020 · 3 comments · Fixed by #507
Labels
good first issue Good for newcomers

Comments

@sarahrobichaud
Copy link

sarahrobichaud commented May 25, 2020 •
edited
Loading

I often find my myself leaving it in playbar only screen / basic view while listening to new playlists/discover weekly, it would be nice to not have to back out of it and just tap s to like the currently playing song.
@Rigellute
Copy link
Owner

You're right, that would be good 👍

@Rigellute Rigellute added the good first issue Good for newcomers label May 27, 2020
@tysaya123
Copy link

I was able to add the request in by taking a little code from playbar.rs. Should I fork and create a pull request?

@Ricardo-HE
Copy link
Contributor

I think you should submit a PR if you think you successfully added the feature. I was able to solve the issue as well, if you want I can submit the PR.

@Ricardo-HE Ricardo-HE mentioned this issue Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add feature to like a song from basic view
4 participants
@Rigellute @tysaya123 @Ricardo-HE @sarahrobichaud