New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model child node properties better #13
Comments
Perhaps it is necessary to allow property values that are XML elements to be specified as |
I think ideally properties that are represented by XML elements should be treated equally as those represented by XML attributes. |
Yea, exactly. Adding a
|
Interesting, thanks for explaining some of your thoughts.
|
Yea, I think there are easier ways here than expanding BuilderLookup after looking things over. I think defering this logic to I'm probably not going to get a chance to work on this for a while, feel free to take a stab at it if you're interested. My next chunk of time is probably going to be focusing on enhancing the high level code generation API's and integrating with |
Agreed, perhaps such logic would be best handled by the parent. I'll have a think about it and if I do get some time I might take a look and PR my changes. Looking forward to seeing this project evolve, will definitely be keeping a close eye on things and contributing where I can! |
I pushed up some improvements here, such that the property can provide a mapping for a child node. Turned out to be pretty easy, and I needed to do it to clean up the modeling of commands a bit in preparation for I was able to get rid of a global hack for Thanks for talking me through it though! |
Eject models XML attributes to properties pretty well, but it does not model XML elements to properties very well. This usually just works, so it's not a big deal, but currently there's no way to inject a node value into the constructor. This is mostly causing issues for
frame
, but also for passing in target actions into UIBarButtonItem.The text was updated successfully, but these errors were encountered: