Code cleanup, comments, analyzer warnings. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Creates a new @c RZUniqueTransition for use with the RZTransition Manager | ||
| * | ||
| * @param action The action that is to be used in the presentation/dismisall of the View controller |
There was a problem hiding this comment.
typo: dismissal. And view controller requires no capital letters.
|
@ZevEisenberg if you want to just make changes using the github inline editor, I am fine with that. It will probably save time for both of us in me going back and updating everything, and you making the comments. |
| /** | ||
| * The View Controller that is being transitioned from. | ||
| */ | ||
| @property(strong, nonatomic) UIViewController *fromViewController; |
|
@Arrouse good call. Will do. |
|
@Arrouse done. |
|
Thanks @ZevEisenberg Appreciate you taking the time to look through it. |
|
@Raizlabs/maintainers-ios I am going to merge this eod. Speak up if you want me to hold off. |
alexrrouse
added a commit
that referenced
this pull request
Jan 8, 2015
Code cleanup, comments, analyzer warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Raizlabs/maintainers-ios This is just some cleanup of this repo.
Any input around the content in comments/code style can just be made on this branch, unless a discussion is desired.