Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library only works when window.rootViewController is RZTransitionNavigationController #16

Open
fladdict opened this issue Apr 13, 2015 · 2 comments

Comments

@fladdict
Copy link

If window.root is jus UIViewController, dismiss transition doesn't really works when pushing modal view.

@karmeye
Copy link

karmeye commented May 22, 2015

I can attest to this as well (regardless of the window.rootViewController).

It seems that the defaultPresentDismissAnimationController is overwriting the specific transitions that are set for the view controller that is presented modally.

So if the default defaultPresentDismissAnimationController is not set, i.e. nil, then it uses the default transition UIKit transition.

As workaround you can do:

id<RZAnimationControllerProtocol> animationController = ...

[[RZTransitionsManager shared] setDefaultPresentDismissAnimationController:animationController];
[self presentViewController:nc animated:YES completion:^{
    [[RZTransitionsManager shared] setDefaultPresentDismissAnimationController:nil];
}];

Same on dismiss:

id<RZAnimationControllerProtocol> animationController = ...

[[RZTransitionsManager shared] setDefaultPresentDismissAnimationController:animationController];
[self dismissViewControllerAnimated:YES completion:^{
    [[RZTransitionsManager shared] setDefaultPresentDismissAnimationController:nil];
}];

This issue is only apparent with RZTransitionAction_PresentDismiss, works as expected with RZTransitionAction_PushPop.

@Arrouse Has this been addressed in the 1.2.0 release?

@jpmhouston
Copy link

Is it related to the issues raised in this SO question/answer?
http://stackoverflow.com/a/25193675/592739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants