Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RZZoomPushAnimationController calls viewWillAppear: #20

Closed
nburatovich opened this issue Jun 10, 2015 · 1 comment
Closed

RZZoomPushAnimationController calls viewWillAppear: #20

nburatovich opened this issue Jun 10, 2015 · 1 comment

Comments

@nburatovich
Copy link

My UIViewController had its viewWillAppear: method getting called twice – once by RZZoomPushAnimationController and then again by the system, causing some unnecessary work to be done. RZZoomPushAnimationController's animateTransition: method explicitly calls [toViewController viewWillAppear:YES]. This seems wrong to me because the system already automatically calls UIViewController's viewWillAppear: when appropriate.

I haven't read any documentation to indicate that viewWillAppear: should ever be explicitly called. Is its use here an undocumented bug workaround or does it need to be called for any reason? I removed it (because that seems like the better alternative than adding a guard to viewWillAppear:) and everything works as expected now (work is not done twice).

@mr-fixit
Copy link
Contributor

mr-fixit commented Dec 1, 2015

thanks for the catch, and sorry for the delay in responding. I just merged the fix to develop, in the PR #33

@mr-fixit mr-fixit closed this as completed Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants