Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RZBaseSwipeInteractionController short circuits interactive transitions [#46] #47

Merged
merged 2 commits into from
Feb 4, 2016

Conversation

bskinner
Copy link
Contributor

@bskinner bskinner commented Feb 3, 2016

  • Fixes an issue where RZBaseSwipeInteractionController was canceled as soon as the gesture started tracking
  • Cleanup RZCirclePushAnimationController after the animation is completed. Fixes an issue where the modal Present animation would end up in a stuck state after canceling a transition.

Blake Skinner added 2 commits February 3, 2016 17:07
- The masking CALayer should be removed after the animation ends
- `super`'s `animateTransiton:` method should be called at the beginning of the method body, otherwise the from and to views are not laid out.
@orionthewake
Copy link

@bskinner This looks good to me. We just need to update the pod spec to 1.2.1 and then merge.

bskinner added a commit that referenced this pull request Feb 4, 2016
…ircuit

RZBaseSwipeInteractionController short circuits interactive transitions. Fixes #46
@bskinner bskinner merged commit f2ba669 into develop Feb 4, 2016
@bskinner bskinner deleted the bugfix/bskinner/46-swipe-short-circuit branch February 4, 2016 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants