Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate self custody feature #31

Open
gabririgo opened this issue Nov 26, 2023 · 0 comments
Open

Deprecate self custody feature #31

gabririgo opened this issue Nov 26, 2023 · 0 comments

Comments

@gabririgo
Copy link
Member

Summary

Remove the unused self-custody feature.

Motivation

The feature was added to provide further flexibility to professional market makers. As the feature never got used and breaks the condition that the pool is the owner of all owned tokens, it does not make sense to keep it. It also adds a point of attack where if the wallet of the pool operator is hacked and the conditions for using the feature are fulfilled, tokens can be transferred out of the pool.

Specification

Remove mapping of self-custody selectors to adapter contract. Remove the self-custody adapter in the authority smart contract.

Rationale

To maintain the integrity of the pool value estimation by the sum of the value of pool-owned tokens.

Notes

Feature code has been removed in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant