Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard warning lights state not set/loaded, when loading a save #2740

Closed
MarkROR opened this issue Apr 23, 2021 · 3 comments · Fixed by #2795
Closed

Dashboard warning lights state not set/loaded, when loading a save #2740

MarkROR opened this issue Apr 23, 2021 · 3 comments · Fixed by #2795

Comments

@MarkROR
Copy link
Contributor

MarkROR commented Apr 23, 2021

When loading a saved game, the parking brake light will show as "off" even if the vehicle's parking brake is on.
Same with the lights indicator (lights activated with n key) - the lights themselves will be on, the flares are shown, but the indicator light is off. Also, the state of turn signals/hazard lights is not saved nor loaded (not sure if it should be? possibly not)

Steps to reproduce

  1. Enter any map, spawn any car (with working lights)
  2. Turn ignition off (x) and turn it back on so the check engine/battery lights come on.
  3. Turn the handbrake on (p) and the main lights (n) and the hazard lights (-)
  4. Exit to main menu
  5. Click "Resume game"

Expected behaviour

  • The state of the functions activated should be the same.
  • The dashboard warning lights should reflect the state of the active functions.

Actual behaviour

  • The state of the functions activated is the same, except for the hazard lights (same result when using turn signals)
  • The dashboard warning lights are off and so showing incorrect state of the active functions.

This isn't a big deal, they reset themselves after you toggle the functions again. Still, can be confusing when you're trying to drive and the handbrake is on when it appears to be off. It's the same situation when using the analog speedometer.

Again, I'm not sure if the state of hazard lights/turn signals should even be saved, but I decided to mention it.

@WillyB1337 WillyB1337 added the bug label Apr 23, 2021
@WillyB1337
Copy link
Collaborator

WillyB1337 commented Apr 23, 2021

I can confirm what is going on.

  • The state of the functions activated is the same, except for the hazard lights (same result when using turn signals)
  • The dashboard warning lights are off and so showing incorrect state of the active functions.
    For vehicles with animated props for the parking-brake, it would stay in the engaged position after loading the save. (I usually restart the game since it's for setting changes)

Probably a simple fix in the form of :
if engaged in save, set parking brake state to true.

@WillyB1337
Copy link
Collaborator

This isn't a big deal, they reset themselves after you toggle the functions again. Still, can be confusing when you're trying to drive and the handbrake is on when it appears to be off. It's the same situation when using the analog speedometer.

For dashboards with both an indicator light and a parking brake switch, they would be reverse.
Like the light would be off but the prop is on.
It requires me to hold the parking brake button to glitch the state.

I gotta say that the save feature is not utilized enough in the community.

It would require a section for it in the official documentation.

@MarkROR
Copy link
Contributor Author

MarkROR commented Apr 23, 2021

I just want to clarify, by dashboard, I meant the GUI dashboard/speedometer, which is unrelated to any mod. Please feel free to change the title if it's misleading, I just don't know the proper terminology.

Testing it with the Thomas Saf-T-Liner, both its own dashboard light and the yellow parking brake pull lever thing are set to the correct state, when loading a game. (the GUI dashboard/speedometer is still showing incorrect state)

Thank you for taking a look into this, I definitely agree this is low-priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants