Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

❓ retrieve a current Binance-USDT-All-Tradable-StaticPairList.json file & "isMarginTradingAllowed==True #63

Closed
pascal00d opened this issue Jun 13, 2021 · 9 comments
Assignees
Labels
Feature - Enhancement Update or improvement to existing feature Question Further information is requested
Milestone

Comments

@pascal00d
Copy link

Hello,

To retrieve a current Binance-USDT-All-Tradable-StaticPairList.json file, in Binance-Retrieve-All-Tradable-StaticPairList.py you check that "isMarginTradingAllowed==True".

With "isMarginTradingAllowed==True" => 131 pairs
Without "isMarginTradingAllowed==True" => 233 pairs

What is the reason to check that "isMarginTradingAllowed==True" ?

@Rikj000 Rikj000 added Feature - Enhancement Update or improvement to existing feature Question Further information is requested labels Jun 13, 2021
@Rikj000 Rikj000 added this to the v0.12.0 milestone Jun 13, 2021
@Rikj000
Copy link
Owner

Rikj000 commented Jun 13, 2021

Hello,

To retrieve a current Binance-USDT-All-Tradable-StaticPairList.json file, in Binance-Retrieve-All-Tradable-StaticPairList.py you check that "isMarginTradingAllowed==True".

With "isMarginTradingAllowed==True" => 131 pairs
Without "isMarginTradingAllowed==True" => 233 pairs

What is the reason to check that "isMarginTradingAllowed==True" ?

Good question, @PoCk3T is the creator of this tool, maybe he can elaborate this.
For now I'll comment it out upon my next commits pushed since indeed this tool's current purpose is mostly to pull All-Tradable pairs! (Together with some cleanup of the file)

@Rikj000 Rikj000 self-assigned this Jun 13, 2021
@Rikj000 Rikj000 added the In Progress This is being worked on label Jun 13, 2021
@Rikj000
Copy link
Owner

Rikj000 commented Jun 13, 2021

Margin trade limitation disabled in commit: 499f4d5

@Rikj000 Rikj000 closed this as completed Jun 13, 2021
@Rikj000 Rikj000 removed the In Progress This is being worked on label Jun 13, 2021
@pascal00d
Copy link
Author

Thanks for your work !

@PoCk3T
Copy link
Contributor

PoCk3T commented Jun 14, 2021

As far as I remember, some of the pairs that shows up if you remove "isMarginTradingAllowed==True" are simply not traded anymore

@3ylo
Copy link
Contributor

3ylo commented Jun 14, 2021

As far as I remember, some of the pairs that shows up if you remove "isMarginTradingAllowed==True" are simply not traded anymore

I wonder if it is related to leveraged pairs used on margin trading.If that's the case I believe they will be blacklisted because of the high risk.
https://academy.binance.com/en/articles/what-is-margin-trading
https://academy.binance.com/en/articles/a-beginners-guide-to-binance-leveraged-tokens-blvt

@Rikj000 Rikj000 reopened this Jun 14, 2021
@Rikj000
Copy link
Owner

Rikj000 commented Jun 14, 2021

As far as I remember, some of the pairs that shows up if you remove "isMarginTradingAllowed==True" are simply not traded anymore

Can't find much on the matter besides this: https://dev.binance.vision/t/ismargintradingallowed-the-same-as-shortable/2274
It's function is clear though, to only leave pairs in the list that are margin trade-able.

But if you say that pairs would be added that are not traded anymore, then do you mean not available anymore?
Or do you mean still available but quite unpopular?

@PoCk3T
Copy link
Contributor

PoCk3T commented Jun 14, 2021

With "isMarginTradingAllowed==True" => 131 pairs
Without "isMarginTradingAllowed==True" => 233 pairs
Delta = 102 pairs

Very concretely, if we remove "isMarginTradingAllowed==True", get a list of pairs, and try to download OHCLV data for these pairs, Binance will tell you 102 of these pairs don't exist and the freqtrade download-data tool will ask you to remove these pairs from your list.

Additionally, pick one of these 102 pairs, and as far as I've seen myself, you will see these are old shitcoins

@Rikj000
Copy link
Owner

Rikj000 commented Jun 14, 2021

Very concretely, if we remove "isMarginTradingAllowed==True", get a list of pairs, and try to download OHCLV data for these pairs, Binance will tell you 102 of these pairs don't exist and the freqtrade download-data tool will ask you to remove these pairs from your list.

Alright that settles it 😄 and d['isMarginTradingAllowed'] is True shall remain uncommented 🙂

@Rikj000
Copy link
Owner

Rikj000 commented Jun 14, 2021

Re-enabled in commit: f726c79

@Rikj000 Rikj000 closed this as completed Jun 14, 2021
@Rikj000 Rikj000 changed the title retrieve a current Binance-USDT-All-Tradable-StaticPairList.json file & "isMarginTradingAllowed==True ❓ retrieve a current Binance-USDT-All-Tradable-StaticPairList.json file & "isMarginTradingAllowed==True Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature - Enhancement Update or improvement to existing feature Question Further information is requested
Development

No branches or pull requests

4 participants