Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cli and refactor #44

Merged
merged 5 commits into from May 9, 2022
Merged

update cli and refactor #44

merged 5 commits into from May 9, 2022

Conversation

hasheemi
Copy link

@hasheemi hasheemi commented May 1, 2022

PR (pull request) ini mengandung update yang ada di PR #36 dengan sedikit perubahan dan perbaikan
Isi PR ini :

  • update cli dan menambahkan command run dan compile
  • fixing bug di regex
  • penghapusan openGroup dan closeGroup supaya menghemat baris kode :v
  • edit readme.md
  • penambahan package chalk@4.1.0 dan commander@9.2.0

preview cli:
run single file
image
run multi file
image
compile singe file
image
compile multi file
image
hasil compile
image

hope you like this and thank you

@RioChndr
Copy link
Owner

RioChndr commented May 1, 2022

thank you to refactor this project. please provide unit testing too, to make sure this run perfectly

@hasheemi
Copy link
Author

hasheemi commented May 1, 2022

Oh i know , i Will do it

@hasheemi
Copy link
Author

hasheemi commented May 1, 2022

done
image

@RioChndr
Copy link
Owner

RioChndr commented May 1, 2022

Thank you so much for your hardwork, this is awesome.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@hasheemi hasheemi requested a review from RioChndr May 3, 2022 00:53
@hasheemi
Copy link
Author

hasheemi commented May 3, 2022

i add some description about -c (for compile) flag and change command to syntax

@RioChndr
Copy link
Owner

RioChndr commented May 9, 2022

Thank you so much for refactor this project.
Sorry slow response. Saya akan review di branch khusus sebelum ke main. terima kasih banyak atas bantuan dan kerja kerasnya.

@RioChndr RioChndr changed the base branch from main to refactor May 9, 2022 03:10
@RioChndr RioChndr merged commit 0b55b82 into RioChndr:refactor May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants