Dependency Resolution Broken on Windows 7

[tknerr]

Hey guys,

following the awesome cookbook authoring guide from Jamie Winsor I git stuck after adding the depends "artifact", "~> 0.10.7" tp metadata.rb.

What I got on the next bundle exec vagrant provision is this:

W:\tmp\myface>bundle exec vagrant provision
[Berkshelf] installing cookbooks...
[Berkshelf] Using myface (0.0.1) at path: 'W:/tmp/myface'
W:/tools/vagrant/vagrant/vagrant/embedded/lib/ruby/gems/1.9.1/gems/berkshelf-0.6.0.beta1/lib/berkshelf/downloader.rb:91:in `download': Cookbook 'artifact'
f the default locations (Berkshelf::CookbookNotFound)
        from W:/tools/vagrant/vagrant/vagrant/embedded/lib/ruby/gems/1.9.1/gems/berkshelf-0.6.0.beta1/lib/berkshelf/resolver.rb:127:in `install_source'
        from W:/tools/vagrant/vagrant/vagrant/embedded/lib/ruby/gems/1.9.1/gems/berkshelf-0.6.0.beta1/lib/berkshelf/resolver.rb:47:in `add_source'
        from W:/tools/vagrant/vagrant/vagrant/embedded/lib/ruby/gems/1.9.1/gems/berkshelf-0.6.0.beta1/lib/berkshelf/resolver.rb:71:in `block in add_source_
        from W:/tools/vagrant/vagrant/vagrant/embedded/lib/ruby/gems/1.9.1/gems/berkshelf-0.6.0.beta1/lib/berkshelf/resolver.rb:68:in `each'
        from W:/tools/vagrant/vagrant/vagrant/embedded/lib/ruby/gems/1.9.1/gems/berkshelf-0.6.0.beta1/lib/berkshelf/resolver.rb:68:in `add_source_dependenc
        from W:/tools/vagrant/vagrant/vagrant/embedded/lib/ruby/gems/1.9.1/gems/berkshelf-0.6.0.beta1/lib/berkshelf/resolver.rb:26:in `block in initialize'
        from W:/tools/vagrant/vagrant/vagrant/embedded/lib/ruby/gems/1.9.1/gems/berkshelf-0.6.0.beta1/lib/berkshelf/resolver.rb:25:in `each'
        from W:/tools/vagrant/vagrant/vagrant/embedded/lib/ruby/gems/1.9.1/gems/berkshelf-0.6.0.beta1/lib/berkshelf/resolver.rb:25:in `initialize'
        from W:/tools/vagrant/vagrant/vagrant/embedded/lib/ruby/gems/1.9.1/gems/berkshelf-0.6.0.beta1/lib/berkshelf/berksfile.rb:335:in `new'
...

Next I tried berks install but got the same problem:

W:\tmp\myface>berks install
Using myface (0.0.1) at path: 'W:/tmp/myface'
Cookbook 'artifact' not found in any of the default locations

My Berksfile looks like this:

site :opscode

metadata

and this is my metadata.rb:

name             "myface"
maintainer       "YOUR_NAME"
maintainer_email "YOUR_EMAIL"
license          "All rights reserved"
description      "Installs/Configures myface"
long_description IO.read(File.join(File.dirname(__FILE__), 'README.md'))
version          "0.0.1"

depends "artifact", "~> 0.10.7"

I have tried several things like using site 'http://cookbooks.opscode.com/api/v1/cookbooks' instead of site :opscode, using a different cookbook ("mysql") with and without version constraints, but it didn't make a difference.

Am I doing something wrong?

Windows7 64-Bit, Ruby 1.9.3p125, berkshelf 0.6.0.beta1

[reset]

I'll take a look and see if I can reproduce this

[tknerr]

Cool, thanks! Btw: is there a debug switch that I could turn on for more logging output?

[reset]

No - what kind of information are you looking for?

[tknerr]

Nothing specifically, just some kind of debug logging if you will. Thought there might be --verbose flag or so...

[tknerr]

Just tried 0.6.0.beta2, but still the same issue :-/

site 'http://cookbooks.opscode.com/api/v1/cookbooks'
cookbook 'nagios'

W:\tmp\myface>berks install
Cookbook 'nagios' not found in any of the default locations

@reset : could you reproduce this on a Windows box?

[reset]

I haven't had a chance to attempt to reproduce it just yet. I don't have immediate access to Windows machines - I unfortunately need to go find one.

[justincampbell]

@tknerr I'm unable to reproduce this with a new Berkshelf cookbook with metadata depending on nagios, or just an empty directory with the Berksfile above. Could you push a repo that recreates the issue?

[tknerr]

Just cloned master today, built the gem and followed the first three steps of http://berkshelf.com/, which is probably the most simple scenario.

I'm running

V:\tmp\bstest2>bundle exec berks init
      create  Berksfile
      create  Gemfile
Successfully initialized

Then edit the Berksfile:

site :opscode

cookbook 'mysql'
cookbook 'nginx', '~> 0.101.5'

Then again I get the same issue upon berks install:

V:\tmp\bstest2>bundle exec berks install
Cookbook 'mysql' not found in any of the default locations

If its not something specific to my Windows 7 64-Bit installation, I suspect it might be some "bad" dependencies in my Gemfile.lock

Here's my Berksfile, Gemfile and Gemfile.lock: https://gist.github.com/3944902

[tknerr]

I could finally trace it down to this line:
https://github.com/RiotGames/berkshelf/blob/master/lib/berkshelf/locations/site_location.rb#L56

It seems that I get a Permission Denied error when moving the file from the temporary location to the berkshelf:
Permission denied - (C:/Users/tkn/AppData/Local/Temp/d20121028-11204-fu4f3j/mysql, X:/home/.berkshelf/cookbooks/mysql-1.3.0)

[tknerr]

No clue why, but FileUtils.mv in line #56 fails when moving the directory (note: you need to set force: false otherwise the error is silently swallowed):

FileUtils.mv(File.join(dir, name), cb_path, force: false)

On the other hand, doing an explicit copy / delete works:

FileUtils.cp_r(File.join(dir, name), cb_path)
FileUtils.rm_rf(File.join(dir, name))

[tknerr]

This seems to be a common issue under windows, which could be caused by a virus scanner, as I read from here: http://www.ruby-forum.com/topic/1044813

[reset]

Merged changes from @tknerr and closing. If this is still a problem please re-open the issue.