Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sett's passive image (full) on DDragon API is that of ChoGath #470

Closed
Vianpyro opened this issue Apr 8, 2021 · 2 comments
Closed

Comments

@Vianpyro
Copy link

Vianpyro commented Apr 8, 2021

Bug Description
Sett's passive full image available on DDragon API is that of ChoGath.

Problem Description
When we load Sett's JSON file and execute a query (or open from a web browser) on the image of his passive we get the image of Cho'Gath's passive.

Expected Result
I expected to get the image of Sett's passive.

Actual Result
I got the image if ChoGath's passive, with a different name.

Developer Impact
I'm developing a website for me and a few friends using DDragon requests to fetch the latest data, and the image of Sett's passive isn't the one that should be displayed.

  • Frequency: Every API call. Once every 1 API calls.
  • Severity: When it happens, the image of Sett's passive is just not his.
  • Cost: None.
  • Efficiency: Requires me to search the whole API to find manually if there is a way to get the image of Sett's passive automaticaly.
  • User emails: I get a few messages on Discord from people asking me to fix it (not a big issue).

Player Impact
It is a minor issue for League of Legends players.

  • Frequency: Every time the user visits the site, they experience this issue.
  • Severity: When this bug happens, a user see incorrect information about one Champion. I have 150 visits to my site each day.
  • Quantity: There are ~50 players that experience this issue.
  • Region: This affects players in every server.

Preconditions
A request to the API must be done.

Repro Steps

  1. Load Sett's JSON from the DDragon API.
  2. Search for "Sett > passive > image > full" and use the name of the image for the next request.
  3. Execute a request to the image of Sett's passive and see the result.

Issue Comments
This issue is not a major issue and does not need to be fixed urgently, a fix would be appreciated though.

Image of Sett's passive: Sett's passive
Image of Cho'Gath's passive: Cho'Gath's passive

@bangingheads
Copy link

This has been resolved in 11.8.1 https://ddragon.leagueoflegends.com/cdn/11.8.1/img/passive/Sett_P.Sett.png

@Vianpyro
Copy link
Author

Thank you very much for this quick resolution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants