Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match-V4 matchlists/by-account endTime filter causes Bad Request #48

Closed
M0kY opened this issue Dec 25, 2018 · 1 comment
Closed

Match-V4 matchlists/by-account endTime filter causes Bad Request #48

M0kY opened this issue Dec 25, 2018 · 1 comment

Comments

@M0kY
Copy link

M0kY commented Dec 25, 2018

Precondition

  1. Operation: /lol/match/v4/matchlists/by-account/{encryptedAccountId}
  2. Query parameter endTime is provided
  3. Query parameter beginTime is NOT provided

Steps to reproduce

  1. Run operation /lol/match/v4/matchlists/by-account/{encryptedAccountId} with following parameters
  2. Encrypted accountId: grMQPgTIj1lQ61KV-0zCWNLfdj9tJtCTmGOYgARKOtycYw
  3. Query parameter endTime: 1545609984161
  4. Set REGION to: EUW1

Expected Result

As per description of endTime

The end time to use for filtering matchlist specified as epoch milliseconds. If beginTime is specified, but not endTime, then endTime defaults to the the current unix timestamp in milliseconds. If endTime is specified, but not beginTime, then beginTime defaults to the start of the account's match history. If both are specified, then endTime should be greater than beginTime.

when beginTime is not provided the result should be a list of matches from the start of the account match history to the provided endTime or 404 if there is no data.

In this case if endTime is left blank the result contains an array of 100 games.

Actual Result

{
    "status": {
        "status_code": 400,
        "message": "Bad request"
    }
}

Edit: C/P-ed wrong error, added region to steps to reproduce.

@RiotTuxedo RiotTuxedo added the pending: acknowledged We're aware of this issue and are investigating. label Jan 8, 2019
@RiotTuxedo RiotTuxedo added topic: riot games api type: inconsistency Typos, dead links, out dated information, or weird behavior. labels Jan 29, 2019
@RiotTuxedo
Copy link
Contributor

RiotTuxedo commented Feb 28, 2019

This is related to #28 and #50. The maximum time range allowed is one week, otherwise a 400 error code is returned. I'm making the issue closed: duplicate for our purposes. These issues are related to the same documentation problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants