Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] V5 match list with type=ranked contains Clash games #667

Open
CurtisGreen opened this issue Jul 29, 2022 · 6 comments
Open

[BUG] V5 match list with type=ranked contains Clash games #667

CurtisGreen opened this issue Jul 29, 2022 · 6 comments

Comments

@CurtisGreen
Copy link

CurtisGreen commented Jul 29, 2022

Bug Description
V5 match list with type=ranked contains Clash games when it should only contain solo/duo and flex games

Expected Result
When I pass in type=ranked to /lol/match/v5/matches/by-puuid/{puuid}/ids I expect ranked solo/duo and ranked flex games

Actual Result
I get ranked solo/duo, ranked flex, and Clash games

Developer Impact

  • Frequency: Every API call
  • Efficiency: Requires either extra match history calls or extra match calls

Player Impact

  • Frequency:
    • The client seems to use this filter so every clash the scouting page -> ranked tab will show incorrect data (as it counts ranked and clash together). If a player read both pages they would double count clash games
    • Every time the user visits any site that uses ranked or clash games they will have slightly longer load times for recent ranked match history due to extra requests
  • Region: All

Issue Comments

  • type=ranked including clash games is misleading to developers
  • The in-client clash scouting page shown before clash games seems to use this filter and gives misleading data to the user by including clash games in the ranked match history tab. Because there are separate Clash and Ranked tabs in the scouting page it’s not clear to players that Clash champions are being double counted
  • This causes a slight increase in the number of requests as developers either need to query match history for clash games then throw them away, or query match history for ranked solo/duo and flex separately
@CurtisGreen CurtisGreen changed the title [BUG] [BUG] V5 match list with type=ranked contains Clash games Jul 29, 2022
@geozukunft
Copy link

This is not a bug but rather intentional it is considered to be within the group of ranked type games as it falls within the category of competitive game modes even if there is no ranked ladder attached to it.

@CurtisGreen
Copy link
Author

CurtisGreen commented Dec 7, 2022

Interesting, if that is the case I still think it’s misleading when looking at how Riot and 3rd party developers mostly use the API. My last two bullet points give good examples of the negative effects of this, do you know of any positive effects that I might be unaware of?

Thanks

Edit:

I updated the 2nd to last bullet in the post with more information, I’ll clarify here too. In the clash scouting page there are 3 tabs: mastery, ranked, and (clash) history.

History shows only champions played in clash games whereas Ranked shows champions played in solo/duo, flex and clash. This is misleading because clash has its own tab one would expect it to not be counted in any other tabs. Some players count games & win rate between tabs to get a fuller picture and in this case they would be double counting clash games.

@DarkIntaqt
Copy link

Note: ARAM clash does not appear within the ranked filter. This leads to further inconsistencies with the query options in match v5.
Therefore, this issue is maybe not as "unnecessary" as stated before.

@geozukunft
Copy link

To respond to the last part of the previous response from @CurtisGreen in the end you still need the clash + ranked games and if you download the games themself you will know which game it was exactly anyway. And I'd say that the low quantity of Clash games would not warrant giving it a seperate filter option that would be my best guess on why Riot decided to structure it this way.

@CurtisGreen
Copy link
Author

Yeah I don’t think clash should have its own filter unless they start doing many different kinds of clash like ARAM clash which have different queue IDs. I just think removing clash from the ranked filter would benefit both Riot and 3rd party devs.

This is obviously opinionated, so to start off I would just like to make sure this is intentional by Riot. If it is intentional and they still want it to be like that then so be it

@geozukunft
Copy link

Maybe @RiotTuxedo can give us some insight as he worked on it afaik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants