Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Overlapping summoner in league/v4/entries and league-exp/v4/entries paginated results #685

Open
JoschuaGoetz opened this issue Sep 14, 2022 · 0 comments

Comments

@JoschuaGoetz
Copy link

Bug Description
There are overlapping players between pages. The last 5 players of page 1 are also the first 5 players of page 2.
This happens here
https://developer.riotgames.com/apis#league-exp-v4/GET_getLeagueEntries
and here https://developer.riotgames.com/apis#league-v4/GET_getLeagueEntries

Problem Description
This duplicates entries and does waste space.

Expected Result
Pages produce a distinct set of players in a league

Actual Result
5 players per page are overlapping

Repro Steps

  1. Call https://developer.riotgames.com/apis#league-exp-v4/GET_getLeagueEntries with page 1
  2. Call https://developer.riotgames.com/apis#league-exp-v4/GET_getLeagueEntries with page 2
  3. compare the total amount of players in both pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants