Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support search history? #6

Open
v6cc opened this issue Dec 28, 2020 · 3 comments
Open

support search history? #6

v6cc opened this issue Dec 28, 2020 · 3 comments

Comments

@v6cc
Copy link

v6cc commented Dec 28, 2020

hope support use <c-n> <c-p> in insert mode to get history search

@RishabhRD
Copy link
Owner

Not sure about it. It means the plugin has to maintain an array of old search
entries. And its size would increase with every usage of the plugin. I am just
thinking can we utilize some vim/neovim capability here so that we don't have
to use the list. Do you have any vim/neovim feature in mind that can help us
to implement this with O(1) memory usage?

@v6cc
Copy link
Author

v6cc commented Dec 29, 2020

@RishabhRD May be just maintain recent 10 search history? too many seems not useful

@RishabhRD
Copy link
Owner

RishabhRD commented Jan 7, 2021

@zdmgmail maintaining 10 in search history would be a sort of hack. However, if
done using a command also, like vimscript command, it would maintain history.
So, we can't escape from memory usage. Hence, I thought we can maintain it
ourselves to get more control.

Just update popfix and nvim-cheat.sh to get the feature. 😃

I have updated readme for the new mappings.

Thanks for such a valuable suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants