Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing To Do list: part 1 #6

Merged
merged 5 commits into from Jun 9, 2022
Merged

Testing To Do list: part 1 #6

merged 5 commits into from Jun 9, 2022

Conversation

RitobrotoMukherjee
Copy link
Owner

@RitobrotoMukherjee RitobrotoMukherjee commented Jun 9, 2022

Test add and delete item functionality

  • It's a pair programming task.
  • Set up the project with jest
  • Set up babel package and configuration to use ES6 as CommonJS by the jest
  • Followed AAA pattern.
  • Mocked localStorage from the super(parent) class as an empty array before each test initialization inside describe scope.
  • Implemented fake mocking of external services from parent class.
  • Done mock implementation of 2 functions - 1. setList and 2. reOrderTaskIndex of TaskList class (Parent Class) used by the unit testing class CRUD (Child Class).
  • Added tests to add / remove exactly 1 item from the mock implemented local storage list while the tests run, and checked it using the comparison between updated list size and previous list size.

Copy link

@Omar-Muhamad Omar-Muhamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✔

Hi @RitobrotoMukherjee and @divinecharlotte,

Great job, Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

thumbs-up-agree

(Highlights) Good Points: 👍

  • You documented your work professionally. ✔
  • Github flow is used correctly. ✔
  • All linters checks are ok. ✔

(Changes Required) Aspects to improve: ♻️

  • N/A

[Optional] suggestions:

  • N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

**Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@divinecharlotte divinecharlotte merged commit 33e3950 into master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants