Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing To Do list: part 2 #7

Merged
merged 4 commits into from Jun 9, 2022
Merged

Testing To Do list: part 2 #7

merged 4 commits into from Jun 9, 2022

Conversation

RitobrotoMukherjee
Copy link
Owner

Test Updates of tasks, and Clear Completed Status

  • It's a pair programming task.
  • Set up the project with jest
  • Set up babel package and configuration to use ES6 as CommonJS by the jest
  • Followed AAA pattern.
  • Mocked localStorage from the super(parent) class as an empty array before each test initialization inside describe scope.
  • Implemented fake mocking of external services from parent class.
  • Done mock implementation of 2 functions - 1. setList and 2. reOrderTaskIndex of TaskList class (Parent Class) used by the unit testing class CRUD (Child Class) & CompletedTask (Completed Task Class).
  • Added tests for editing the task description, updating an item's 'completed' status, and Clear all completed with reordering list and save to local storage.
  • Used localStorage functionality from part 1. Re-order index implemented in this test.
  • All tests for different classes are grouped with describe function respectively.

Copy link

@ShadyShawkat ShadyShawkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Image

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@RitobrotoMukherjee RitobrotoMukherjee merged commit 7241f08 into master Jun 9, 2022
@github-pages github-pages bot temporarily deployed to github-pages June 9, 2022 13:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants