Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup in Deck description not allowing some basic Markup - Medium Priority #70

Open
Robsmash138 opened this issue Jul 2, 2024 — with Linear · 2 comments
Open
Labels
bug Something isn't working

Comments

Copy link
Contributor

"It works for the headings and bold, but paragraph and line breaks don't work. Interesting that some work but not others" - Mr. Fuji reports from Unofficial Rivals

@Robsmash138 Robsmash138 added the bug Something isn't working label Jul 2, 2024 — with Linear
Copy link

linear bot commented Jul 2, 2024

@stopfstedt
Copy link
Collaborator

looks like we need to explicitly enable Github Flavored Markdown line-breaks when converting markdown to markup, using toHtmlWith instead of toHtml.

see https://package.elm-lang.org/packages/elm-explorations/markdown/latest/Markdown

code changes will need to happen in this file: https://github.com/RivalsDB/rivalsdb/blob/master/client/src/UI/Markdown.elm

might as well enable support for Markdown tables while at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants