Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_skipped can't parse zeros #9

Closed
orlp opened this issue Nov 28, 2023 · 0 comments · Fixed by #10
Closed

parse_skipped can't parse zeros #9

orlp opened this issue Nov 28, 2023 · 0 comments · Fixed by #10

Comments

@orlp
Copy link
Contributor

orlp commented Nov 28, 2023

parse_skipped strips all leading zeros, but this will cause atoi_simd::parse_skipped(b"0") to return Err(Empty).

Some test cases that should all parse to zero:

assert_eq!(parse_skipped::<i8>(b"0"), Ok(0));
assert_eq!(parse_skipped::<i8>(b"-0"), Ok(0));
assert_eq!(parse_skipped::<i8>(b"-0000000000000000000000000000"), Ok(0));
assert_eq!(parse_skipped::<i8>(b"+0"), Ok(0));
assert_eq!(parse_skipped::<i8>(b"+0000000000000000000000000000"), Ok(0));
assert_eq!(parse_skipped::<u8>(b"0"), Ok(0));
assert_eq!(parse_skipped::<u8>(b"+0"), Ok(0));
assert_eq!(parse_skipped::<u8>(b"+0000000000000000000000000000"), Ok(0));

and repeated for i16, i32, i64, i128 and u16, u32, u64, u128.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant