Shift-clicking items from the hotbar into a brewing stand with an empty fuel meter and empty fuel slot deletes them

[Yishua]

Version: 2.4.0

Describe the bug
Items shift-clicked into the new Brewing Stand are deleted.

To Reproduce

1. Open a 'new' Brewing Stand with no fuel (Blaze Powder)
2. Shift-click any item that ISN'T Blaze Powder
3. The item will be deleted, this does not happen when shift-clicking Blaze Powder

[Roadhog360]

simplescreenrecorder-2022-08-14_11.05.51.webm

In this video, I am spamming shift-click on all items.

Please post a video of you reproducing this, and be positive you're actually on 2.4.0.
Mods list would be appreciated, this is probably a mod conflict.

[Yishua]

The brewing stand must have no fuel in it, I mentioned this initially. Here is a recording with nothing but Forge installed

brewing.stand.bug.mp4

[Roadhog360]

Hello, in my video you can see I try with and without fuel and I still cannot reproduce this.

[GregoriusT]

Can I see the fml-client-latest.log? Forge has a setting that deletes erroring TileEntities, and it MIGHT cause the brewing Stand TileEntity to be deleted without the Brewing Stand itself vanishing.

[Yishua]

Hello, in my video you can see I try with and without fuel and I still cannot reproduce this.

When I say fuel I mean this bar being full

[Yishua]

Can I see the fml-client-latest.log? Forge has a setting that deletes erroring TileEntities, and it MIGHT cause the brewing Stand TileEntity to be deleted without the Brewing Stand itself vanishing.

latest.log

[GregoriusT]

Why do people always give the latest.log when i specifically ask for fml-client-latest.log ?

[Yishua]

Why do people always give the latest.log when i specifically ask for fml-client-latest.log ?

Because that's all there is in the logs directory, where most people look for logs.

[Roadhog360]

Hello, in my video you can see I try with and without fuel and I still cannot reproduce this.

When I say fuel I mean this bar being full

Confirmed

[Roadhog360]

Weird, I am looking at the code for the new brewing stand's transferStackInSlot and nothing refers to the fuel level for shift clicking. I'm hoping this doesn't turn into another SoS issue...

[GregoriusT]

The Issue likely is not the shiftclicking itself, but might actually be the Recipe Logic instantly reacting to the Item you insert? Or did you already find the actual Issue? It was hard to see in that commit because it rewrote the entire shiftclick logic.

---

Because that's all there is in the logs directory, where most people look for logs.

Wait WHAT?! This is what is SUPPOSED to be in the logs Folder along with the .log.gz things:

fml-client-1.log
fml-client-2.log
fml-client-3.log
fml-client-latest.log
fml-junk-earlystartup.log
latest.log

And you are telling me you have Forge installed, which to my knowledge is definitely a prerequisite for installing Et Futurum Requiem, and these Forge Logs do not exist in the logs Folder?

Did Windows somehow end up hiding the Files? Can you look at the content of this Folder with viewing hidden Files enabled? I just have to know what exactly went wrong there...

[makamys]

My guess is that some launchers (Technic in this case) use a custom log4j config that cause the fml-client-latest.log file to not get created.

[GregoriusT]

Gotta love just blindly killing all the logging instead of doing the sensible thing and replacing it with a basic System.out.println to a basic text File...