Raw copper has no output if EFR copper is off

[Roadhog360]

Please check any boxes that apply to you and your issue

• I use a translator application to post this issue.

• This is a crash. Please upload, Pastebin, Gist or copypaste the whole crash report along with this issue.

• This is a mod incompatibility. If I do this in vanilla Forge with only Et Futurum Requiem installed, it works normally.

• This is a code problem. Please link the probably problematic lines of code in the issue and/or explain in detail what is wrong.

Version number of Et-Futurum-Requiem (IMPORTANT)

Specify the actual version, please don't just say "latest", tell us the version number of the mod in-game, or the name the jar had when downloading it.

2.4.1 CI f0a1db5

Describe the issue (IMPORTANT)

A list of steps to reproduce the issue may be helpful too. Screenshots could also prove beneficial for visual issues.

If raw ores are enabled but the EFR copper is off, there's no way to smelt it to another mod's copper ingot. Expected result should be it just smelts to a different copper ingot.
Line 721 in ModRecipes is disabled when copper is off, but then there is no alternative present for raw copper only.

[github-actions]

@Roadhog360: hello! 👋

This issue is being automatically closed because it does not follow the issue template.

[Roadhog360]

Go fuck yourself

[GregoriusT]

Lol telling GitHub actions to screw with Issue Reports might not be the smartest thing to do, it might turn the slightest typo into an invalid template message. XD

[Roadhog360]

It is in my best interest to make sure people provide all necessary information.

And besides, I looked at the action file and there was nothing actually checking if the issue used the template, so it must have been unconditionally closing the tickets.

[MikhailTapio]

Could that be done by simply getting 'OreDictionary.getOres("ingotCopper").get(0)'(if it exists) and adding it to the recipe result?

[Roadhog360]

That was the exact plan, yes.

[GregoriusT]

Yeah should work fine, I haven't seen any Mod that adds Copper Ore but doesn't also have Copper ingots,
so the Raw Copper Ore Item should be perfectly unobtainable if no Copper Ingots exist,
meaning this is a safe assumption to make as long as Mods have already registered their Ingots to the OreDict at the time you check the List of Copper Ingots,
and because I have never seen a Mod registering specifically Ingots in PostInit or later (apart from MineTweaker, but that doesn't count), it is fine to do in PostInit.

Also make sure the List is not empty when you try to get(0), because it might end up with an Index Out of Bounds if no Copper exists whatsoever.

[Roadhog360]

Yes, that too.

The raw ores are intended to be compatible with modded copper ores in which the user may prefer another mod's ingot so it needs to be obtainable.