Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assembly signing #69

Closed
Roald87 opened this issue Apr 26, 2021 · 5 comments · Fixed by #74
Closed

Remove assembly signing #69

Roald87 opened this issue Apr 26, 2021 · 5 comments · Fixed by #74
Assignees
Labels
enhancement New feature or request

Comments

@Roald87
Copy link
Owner

Roald87 commented Apr 26, 2021

Github secrets are not available to forked repos. That's why the piplines of the PR's failed from others than mine.

Singing would only be necessary in case of publishing a release. So, it should be possible to remove the required signature when it goes into the pipeline for only builds and tests.

@Roald87 Roald87 added the enhancement New feature or request label Apr 26, 2021
@Roald87 Roald87 self-assigned this Apr 28, 2021
@Roald87
Copy link
Owner Author

Roald87 commented Apr 28, 2021

@Roald87
Copy link
Owner Author

Roald87 commented May 2, 2021

Asked a question on stackoverflow.

@Roald87
Copy link
Owner Author

Roald87 commented May 8, 2021

Bounties the StackOverflow question. If there is no answer, I'll remove the singing. It causes too much trouble.

@Roald87
Copy link
Owner Author

Roald87 commented May 8, 2021

See also #65

@Roald87
Copy link
Owner Author

Roald87 commented May 11, 2021

Removing the singing. This is causing so many headaches and frankly I do not understand the advantages.

@Roald87 Roald87 changed the title Builld and test project without needing signing Remove assembly signing May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant