Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Mode: Improve UX #394

Open
mdroidian opened this issue Mar 26, 2023 · 0 comments
Open

Privacy Mode: Improve UX #394

mdroidian opened this issue Mar 26, 2023 · 0 comments
Assignees

Comments

@mdroidian
Copy link
Collaborator

mdroidian commented Mar 26, 2023

from: #391

Blank roam pages get deleted by default, so WorkBench Privacy Mode List doesn't get created for the user. As a user, this requires multiple clicks/reading to understand how the plugin functions.

Proposed solution:

Create the page with a block of instructions:

  Promise.resolve(
        createPage({ title: roamPageWithPrivacyList })
      ).then((parentUid) =>
        createBlock({ node: { text: `Add \`pages\` or \`tags\` to be redacted below.  By default, the full block tree will be redacted. If you would like to redact just the page name, then add an exclamation mark \`!\`.  See more info at https://roamjs.com/extensions/workbench/privacy_mode` }, parentUid })
      );

Refactor getPrivateBlockDetails() to only include blocks that match a page / tag so that if (!privacyDefined.length) toast triggers only if nothing is defined.

This will also make the redirect to roamPageWithPrivacyList will work again.

Also, rename page to roam/js/privacy-mode to stay consistent with config page naming conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant