Gh 590 immutable roarding64 navigable bitmap #602
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At somer point, I feel ImmutableRoarding64NavigableBitmap shall be a parent class for Roarding64NavigableBitmap. Also, beware ImmutableRoaring64Bitmap suggests being mostly related to Roaring64Bitmap, while I suppose your meant Roarding64NavigableBitmap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is draft, just to share my current work. There is failing test and I want to squash rebase anyway. It is just I had a lot less time than I expected the last two weeks.
This pull request should introduce an new ImmutableRoaring64Bitmap. Considering such a structure maybe larger than 2gigabytes we can't use a single bytebuffer to open it. Instead it takes a RandomAccessFile and builds up the internal ImmutableRoaringBitmaps from mapped sections.
Automated Checks
./gradlew testand made sure that my PR does not break any unit test../gradlew checkstyleMainor the equivalent and corrected the formatting warnings reported.