Improve RoaringBitmap ref with ref set operations #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded: |
|
Hey @MarinPostma, if you got time, could you take a look at this PR, please? 馃槂 |
Kerollmops
changed the title
Kerollmops
force-pushed
the
improve-ref-ref-ops
branch
4 times, most recently
from
c61c727
to
db90b25
Compare
MarinPostma
suggested changes
May 3, 2021
Kerollmops
force-pushed
the
improve-ref-ref-ops
branch
2 times, most recently
from
b25ade8
to
b5738cf
Compare
MarinPostma
suggested changes
May 31, 2021
Kerollmops
force-pushed
the
improve-ref-ref-ops
branch
2 times, most recently
from
f41f311
to
89e9750
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 1, 2021
102: Improve RoaringBitmap ref with ref set operations r=Kerollmops a=Kerollmops This is a follow-up of the #97 PR. It improves the specific `&RoaringBitmap` with `&RoaringBitmap` `union`, `intersection` `difference` and, `symmetric difference` operations. The previous implementation was cloning the smallest or biggest bitmap depending on the operation and applying an `_assign` operation on it, this was not quite efficient. In this new implementation, we no more clone the containers `Vec` but rather collect the required `Container`s from the left-hand side or the right-hand side. The performance gain is around 20% 馃帀 馃殌 Co-authored-by: Cl茅ment Renault <clement@meilisearch.com> Co-authored-by: Kerollmops <clement@meilisearch.com>
|
Build failed: |
Kerollmops
force-pushed
the
improve-ref-ref-ops
branch
from
89e9750
to
724e308
Compare
|
bors try |
tryBuild succeeded: |
|
I will first introduce the |
Kerollmops
force-pushed
the
improve-ref-ref-ops
branch
2 times, most recently
from
d27d026
to
b8556b2
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 2, 2021
102: Improve RoaringBitmap ref with ref set operations r=Kerollmops a=Kerollmops This is a follow-up of the #97 PR. It improves the specific `&RoaringBitmap` with `&RoaringBitmap` `union`, `intersection` `difference` and, `symmetric difference` operations. The previous implementation was cloning the smallest or biggest bitmap depending on the operation and applying an `_assign` operation on it, this was not quite efficient. In this new implementation, we no more clone the containers `Vec` but rather collect the required `Container`s from the left-hand side or the right-hand side. The performance gain is around 20% 馃帀 馃殌 <img width="975" alt="Capture d鈥檈虂cran 2021-06-02 a虁 15 08 02" src="https://user-images.githubusercontent.com/3610253/120485432-5f940d80-c3b4-11eb-907c-01a35b0e2ad2.png"> <img width="959" alt="Capture d鈥檈虂cran 2021-06-02 a虁 15 08 13" src="https://user-images.githubusercontent.com/3610253/120485586-8baf8e80-c3b4-11eb-84bb-33f428f34329.png"> Co-authored-by: Cl茅ment Renault <clement@meilisearch.com> Co-authored-by: Kerollmops <clement@meilisearch.com>
|
Build failed: |
Kerollmops
force-pushed
the
improve-ref-ref-ops
branch
from
b8556b2
to
56ac77c
Compare
|
bors merge |
|
Build succeeded: |
not-jan
pushed a commit
to not-jan/roaring-rs
that referenced
this pull request
Aug 31, 2022
102: Improve RoaringBitmap ref with ref set operations r=Kerollmops a=Kerollmops This is a follow-up of the RoaringBitmap#97 PR. It improves the specific `&RoaringBitmap` with `&RoaringBitmap` `union`, `intersection` `difference` and, `symmetric difference` operations. The previous implementation was cloning the smallest or biggest bitmap depending on the operation and applying an `_assign` operation on it, this was not quite efficient. In this new implementation, we no more clone the containers `Vec` but rather collect the required `Container`s from the left-hand side or the right-hand side. The performance gain is around 20% 馃帀 馃殌 <img width="975" alt="Capture d鈥檈虂cran 2021-06-02 a虁 15 08 02" src="https://user-images.githubusercontent.com/3610253/120485432-5f940d80-c3b4-11eb-907c-01a35b0e2ad2.png"> <img width="959" alt="Capture d鈥檈虂cran 2021-06-02 a虁 15 08 13" src="https://user-images.githubusercontent.com/3610253/120485586-8baf8e80-c3b4-11eb-84bb-33f428f34329.png"> Co-authored-by: Cl茅ment Renault <clement@meilisearch.com> Co-authored-by: Kerollmops <clement@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of the #97 PR. It improves the specific
&RoaringBitmapwith&RoaringBitmapunion,intersectiondifferenceand,symmetric differenceoperations.The previous implementation was cloning the smallest or biggest bitmap depending on the operation and applying an
_assignoperation on it, this was not quite efficient. In this new implementation, we no more clone the containersVecbut rather collect the requiredContainers from the left-hand side or the right-hand side.The performance gain is around 20% 馃帀 馃殌