Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a set of benchmarks with real datasets #104

Merged
merged 6 commits into from May 22, 2021
Merged

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented May 2, 2021

In this PR we introduce better benchmarks that use the official real-roaring-datasets repository, specifically the Wikileaks sorted files.

We moved all of the benchmarks in a dedicated library in the benchmarks directory, this helps in isolating the required dependencies from the main crate. In this crate, we added a build.rs file that downloads and unzips the real-world datasets in the OUT_DIR folder (a folder inside the benchmarks/target directory).

We introduced this new benchmarks crate in the README, to make sure that new contributors are aware of it and will more likely run them when modifying the crate and proposing changes.

@Kerollmops Kerollmops force-pushed the better-benchmarks branch 2 times, most recently from 762a739 to 6bb2f7a Compare May 16, 2021 13:22
@Kerollmops
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 16, 2021
@Kerollmops
Copy link
Member Author

bors try

@bors
Copy link
Contributor

bors bot commented May 16, 2021

try

Already running a review

@Kerollmops
Copy link
Member Author

bors try-

@Kerollmops
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 16, 2021
@Kerollmops Kerollmops changed the title Introducea set of benchmarks with real datasets Introduce a set of benchmarks with real datasets May 16, 2021
@Kerollmops
Copy link
Member Author

bors try

@bors
Copy link
Contributor

bors bot commented May 16, 2021

try

Already running a review

@Kerollmops
Copy link
Member Author

bors try-

@Kerollmops
Copy link
Member Author

bors merge

bors bot added a commit that referenced this pull request May 16, 2021
104: Introduce a set of benchmarks with real datasets r=Kerollmops a=Kerollmops

In this PR we introduce better benchmarks that use [the official real-roaring-datasets repository](https://github.com/RoaringBitmap/real-roaring-datasets), specifically the Wikileaks sorted files.

We moved all of the benchmarks in a dedicated library in the benchmarks directory, this helps in isolating the required dependencies from the main crate. In this crate, we added a build.rs file that downloads and unzips the real-world datasets in the `OUT_DIR` folder (a folder inside the `benchmarks/target` directory).

We introduced this new benchmarks crate in the README, to make sure that new contributors are aware of it and will more likely run them when modifying the crate and proposing changes.

Co-authored-by: Clément Renault <clement@meilisearch.com>
Co-authored-by: Kerollmops <clement@meilisearch.com>
@Kerollmops
Copy link
Member Author

bors cancel

@bors
Copy link
Contributor

bors bot commented May 16, 2021

Canceled.

@Kerollmops
Copy link
Member Author

bors merge

bors bot added a commit that referenced this pull request May 16, 2021
104: Introduce a set of benchmarks with real datasets r=Kerollmops a=Kerollmops

In this PR we introduce better benchmarks that use [the official real-roaring-datasets repository](https://github.com/RoaringBitmap/real-roaring-datasets), specifically the Wikileaks sorted files.

We moved all of the benchmarks in a dedicated library in the benchmarks directory, this helps in isolating the required dependencies from the main crate. In this crate, we added a build.rs file that downloads and unzips the real-world datasets in the `OUT_DIR` folder (a folder inside the `benchmarks/target` directory).

We introduced this new benchmarks crate in the README, to make sure that new contributors are aware of it and will more likely run them when modifying the crate and proposing changes.

Co-authored-by: Clément Renault <clement@meilisearch.com>
Co-authored-by: Kerollmops <clement@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented May 16, 2021

Build failed:

@Kerollmops
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented May 22, 2021

Build succeeded:

@bors bors bot merged commit caefca6 into master May 22, 2021
@bors bors bot deleted the better-benchmarks branch May 22, 2021 07:51
@atouchet atouchet mentioned this pull request Jan 1, 2022
not-jan pushed a commit to not-jan/roaring-rs that referenced this pull request Aug 31, 2022
104: Introduce a set of benchmarks with real datasets r=Kerollmops a=Kerollmops

In this PR we introduce better benchmarks that use [the official real-roaring-datasets repository](https://github.com/RoaringBitmap/real-roaring-datasets), specifically the Wikileaks sorted files.

We moved all of the benchmarks in a dedicated library in the benchmarks directory, this helps in isolating the required dependencies from the main crate. In this crate, we added a build.rs file that downloads and unzips the real-world datasets in the `OUT_DIR` folder (a folder inside the `benchmarks/target` directory).

We introduced this new benchmarks crate in the README, to make sure that new contributors are aware of it and will more likely run them when modifying the crate and proposing changes.

Co-authored-by: Clément Renault <clement@meilisearch.com>
Co-authored-by: Kerollmops <clement@meilisearch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant