Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential bug in AndAny function #309

Closed
lemire opened this issue Jun 3, 2021 · 5 comments
Closed

Potential bug in AndAny function #309

lemire opened this issue Jun 3, 2021 · 5 comments

Comments

@lemire
Copy link
Member

lemire commented Jun 3, 2021

This line in AndAny looks suspicious...

roaring/fastaggregation.go

Line 305 in c341035

tmpBitmap.ior(c)

The ior call could return a new container.
@lemire lemire mentioned this issue Jun 3, 2021
Open
@lemire
Copy link
Member Author

lemire commented Jun 3, 2021

@jacksonrnewhouse vouched for this code. Closing.

@lemire lemire closed this as completed Jun 3, 2021
@jacksonrnewhouse
Copy link

I mean, my vouching was just that the code was correct given the current container implementations. It definitely isn't correct given the general contract for ior(). I have a fix I'm about to post.

@jacksonrnewhouse jacksonrnewhouse mentioned this issue Jun 7, 2021
Merged
@lemire
Copy link
Member Author

lemire commented Jun 7, 2021

+1

@Oppen
Copy link
Contributor

Oppen commented Jun 16, 2021

If the fix was merged, shouldn't the issue be closed?

@lemire
Copy link
Member Author

lemire commented Jun 16, 2021

Closing.

@lemire lemire closed this as completed Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lemire @Oppen @jacksonrnewhouse