Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP_Parser v4 introduces a string type declaration on a parameter, breaking PHP 7.1 installations #450

Closed
Ocramius opened this issue Oct 15, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@Ocramius
Copy link
Member

As reported in #448:

The signature of this API changed.

In PHP 7.2, this is not a problem, because removing the type declaration is perfectly fine, but in PHP 7.1, a change in type signature is not allowed in subclasses.

To fix this, we could:

  • add the string hint, and lock onto PHP-Parser v4
  • drop PHP 7.1 support
@Ocramius
Copy link
Member Author

Ocramius commented Dec 7, 2018

Doesn't seem to be still valid, according to current CI runs with ^4.0.4.

Closing.

@Ocramius Ocramius closed this as completed Dec 7, 2018
@Ocramius Ocramius self-assigned this Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant