Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that composer update --dry-run roave/security-advisories is equivalent to checking locked dependencies #59

Closed
Ocramius opened this issue Dec 2, 2019 · 7 comments
Assignees

Comments

@Ocramius
Copy link
Member

Ocramius commented Dec 2, 2019

Also worth investigating if composer require --dry-run --dev roave/security-advisories would work.

This work should be reflected in README.md

@azjezz
Copy link

azjezz commented Dec 2, 2019

Also worth investigating if composer require --dry-run --dev roave/security-advisories would work.

there's no dry-run option in the require command

@Ocramius
Copy link
Member Author

Ocramius commented Dec 2, 2019

@azjezz maybe something worth adding upstream?

@alcohol
Copy link

alcohol commented Dec 2, 2019

require is basically a shortcut for programatically updating your composer.json file with the new requirement (and some magic that determines a constraint if not given), and then running update. So passing the --dry-run from require on to the update command should be feasible I think. But you'd also have to reverse the change to the composer.json file afterwards, and that makes it more tricky. I think an RFC for this would probably be accepted though (submitting a PR would help a lot in that regard 👍).

@azjezz
Copy link

azjezz commented Dec 2, 2019

@alcohol
Copy link

alcohol commented Dec 2, 2019

@azjezz the only (minor) flaw with that is that you hide the output also in case of an error during the dry-run attempt.

@Ocramius
Copy link
Member Author

Ocramius commented Dec 2, 2019

Closing here, handled by @GeeH in #60

@azjezz
Copy link

azjezz commented Dec 2, 2019

@alcohol huh, will check later, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants